Re: ANN: ClojureScript 1.9.854

2017-07-30 Thread David Nolen
The ability to consume node_modules is just an additional feature - it makes no existing features obsolete. David On Sun, Jul 30, 2017 at 3:42 PM, Daniel wrote: > For someone who is new to clojurescript and pretty confused by > clojurescript dependency management in general, does this release o

Re: ANN: ClojureScript 1.9.854

2017-07-30 Thread Leon Grapenthin
Yes, it does make CLJSJS obsolete and the new method is to include Node modules from NPM. CLJSJS was never the one true way, especially for production. It lacked deduplication of transitive dependencies that were not packed per CLJSJS and of course support for dependencies that where are not in

Re: ANN: ClojureScript 1.9.854

2017-07-30 Thread Daniel
For someone who is new to clojurescript and pretty confused by clojurescript dependency management in general, does this release obsolete cljsjs for new projects and what is the new method? On Friday, July 28, 2017 at 4:55:04 PM UTC-5, David Nolen wrote: > > ClojureScript, the Clojure compiler t

Re: ANN: ClojureScript 1.9.854

2017-07-30 Thread Leon Grapenthin
Amazing release, trying it out right now. Just wanted to see if including this works: https://github.com/coopermaruyama/react-web3 I try to :require it via [react-web3 :as w3] Unfortunately this gives me a not-found error. Also I noticed that CLJS indeed downloaded react-web3 to "node_modules"

Re: spec/conform: + vs * differ sometimes, not sure why

2017-07-30 Thread Alex Miller
This is a bug, similar to https://dev.clojure.org/jira/browse/CLJ-2105 and http://dev.clojure.org/jira/browse/CLJ-2003. I've spent a little time on it but have not figured out the exact problem. If you'd like to file it and reference those and/or drop it as a comment on one of those, would be h

Re: [inheritable-var] A wrapper of InheritableThreadLocal to define thread-inheritable variable

2017-07-30 Thread Jiacai Liu
Oh, it's the same issue with your first example, we need to change executor that core/async use. I will add some hook to decorate those frequently-used executor. On Sunday, July 30, 2017 at 3:32:34 PM UTC+8, Didier wrote: > > I think it would be nice if inheritable-var would set! the future exec

Re: [inheritable-var] A wrapper of InheritableThreadLocal to define thread-inheritable variable

2017-07-30 Thread Didier
I think it would be nice if inheritable-var would set! the future executor service on load, so the user doesn't have to. This way it will just work with future also. Just my 2 cent. Here's how to reproduce the issue with core.async: (let [t 1000] (dotimes [x t] (let [foo (inheritable-var