Re: [ANN] data.xml 0.2.0-alpha5

[Herwig Hochleitner]

2017-11-14 15:33 GMT+01:00 Alex Miller :

> Although it looks like that call is intentionally reflective to cover
> several possible types. Probably need to solve that with a cond to check
> for and hint the actual type at the point of the call.
>

Yep, see the corresponding change in data.xml:
https://github.com/clojure/data.xml/commit/ef8d0c816fa8d9c02d759de990bdb2e0042c0d2a#diff-2a9e7af9410568bc9667e92c2a4227c4R126

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] data.xml 0.2.0-alpha5

[Alex Miller]

Although it looks like that call is intentionally reflective to cover 
several possible types. Probably need to solve that with a cond to check 
for and hint the actual type at the point of the call.

On Tuesday, November 14, 2017 at 8:31:48 AM UTC-6, Alex Miller wrote:
>
> I can replicate that in the tupelo tests, but it's coming from enlive, not 
> data.xml. I think enlive needs a type hint on s in this function:
>
> https://github.com/cgrand/enlive/blob/master/src/net/cgrand/xml.clj#L85
>
>
>   actual: java.lang.IllegalAccessException: class clojure.lang.Reflector 
> cannot access class com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl 
> (in module java.xml) because module java.xml does not export 
> com.sun.org.apache.xerces.internal.jaxp to unnamed module @7b0eff2
>  at jdk.internal.reflect.Reflection.throwIllegalAccessException 
> (Reflection.java:423)
> jdk.internal.reflect.Reflection.throwIllegalAccessException 
> (Reflection.java:414)
> jdk.internal.reflect.Reflection.ensureMemberAccess 
> (Reflection.java:112)
> java.lang.reflect.AccessibleObject.slowCheckMemberAccess 
> (AccessibleObject.java:632)
> java.lang.reflect.AccessibleObject.checkAccess 
> (AccessibleObject.java:624)
> java.lang.reflect.Method.invoke (Method.java:539)
> clojure.lang.Reflector.invokeMatchingMethod (Reflector.java:93)
> clojure.lang.Reflector.invokeInstanceMethod (Reflector.java:28)
> *net.cgrand.xml$startparse_sax.invokeStatic (xml.clj:85)*
> *net.cgrand.xml$startparse_sax.invoke (xml.clj:76)*
> *net.cgrand.xml$parse.invokeStatic (xml.clj:99)*
> net.cgrand.xml$parse.invoke (xml.clj:87)
> net.cgrand.xml$parse.invokeStatic (xml.clj:94)
> net.cgrand.xml$parse.invoke (xml.clj:87)
> net.cgrand.enlive_html$xml_parser.invokeStatic (enlive_html.clj:55)
> net.cgrand.enlive_html$xml_parser.invoke (enlive_html.clj:51)
> net.cgrand.enlive_html$eval34196$fn__34197.invoke (enlive_html.clj:103)
>
>>
>>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] data.xml 0.2.0-alpha5

[Alex Miller]

I can replicate that in the tupelo tests, but it's coming from enlive, not 
data.xml. I think enlive needs a type hint on s in this function:

https://github.com/cgrand/enlive/blob/master/src/net/cgrand/xml.clj#L85


  actual: java.lang.IllegalAccessException: class clojure.lang.Reflector 
cannot access class com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl 
(in module java.xml) because module java.xml does not export 
com.sun.org.apache.xerces.internal.jaxp to unnamed module @7b0eff2
 at jdk.internal.reflect.Reflection.throwIllegalAccessException 
(Reflection.java:423)
jdk.internal.reflect.Reflection.throwIllegalAccessException 
(Reflection.java:414)
jdk.internal.reflect.Reflection.ensureMemberAccess (Reflection.java:112)
java.lang.reflect.AccessibleObject.slowCheckMemberAccess 
(AccessibleObject.java:632)
java.lang.reflect.AccessibleObject.checkAccess 
(AccessibleObject.java:624)
java.lang.reflect.Method.invoke (Method.java:539)
clojure.lang.Reflector.invokeMatchingMethod (Reflector.java:93)
clojure.lang.Reflector.invokeInstanceMethod (Reflector.java:28)
*net.cgrand.xml$startparse_sax.invokeStatic (xml.clj:85)*
*net.cgrand.xml$startparse_sax.invoke (xml.clj:76)*
*net.cgrand.xml$parse.invokeStatic (xml.clj:99)*
net.cgrand.xml$parse.invoke (xml.clj:87)
net.cgrand.xml$parse.invokeStatic (xml.clj:94)
net.cgrand.xml$parse.invoke (xml.clj:87)
net.cgrand.enlive_html$xml_parser.invokeStatic (enlive_html.clj:55)
net.cgrand.enlive_html$xml_parser.invoke (enlive_html.clj:51)
net.cgrand.enlive_html$eval34196$fn__34197.invoke (enlive_html.clj:103)



On Monday, November 13, 2017 at 9:04:01 PM UTC-6, Alan Thompson wrote:
>
> I seem to still be getting the JDK 1.9 reflection warning:
>
>
> ~/tupelo > grep data.xml project.clj 
> [org.clojure/data.xml "0.2.0-alpha5"]
>
> > lein test
> lein test tst.tupelo._bootstrap
>
> -
>Clojure 1.9.0-RC1Java 9.0.1
> -
>
> lein test tst.tupelo.array
>
> lein test tst.tupelo.async
>
> lein test tst.tupelo.dev
>
> lein test tst.tupelo.forest
>
> lein test tst.tupelo.forest-examples
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by clojure.lang.Reflector 
> (file:/home/alan/.m2/repository/org/clojure/clojure/1.9.0-RC1/clojure-1.9.0-RC1.jar)
>  
> to method 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(org.xml.sax.InputSource,org.xml.sax.helpers.DefaultHandler)
> WARNING: Please consider reporting this to the maintainers of 
> clojure.lang.Reflector
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> 
>
>
>
>
> On Mon, Nov 13, 2017 at 3:47 PM, Herwig Hochleitner <
> hhochleit...@gmail.com> wrote:
>
>> data.xml is a Clojure contrib library that parses and emits XML.
>>
>> Github: https://github.com/clojure/data.xml
>> Changelog: https://github.com/clojure/data.xml/blob/master/CHANGES.md
>>
>> Information on updating the dependency is here 
>> .
>>
>> 0.2.0-alpha5 fixes a bug with emitting attributes in the builtin `xml:` 
>> namespace. In the process, there was a lot of clean-up work, removing 
>> various partial implementations of the recently introduced pu-map.
>>
>> Michael Blume got rid of reflection warnings. This should also remove the 
>> "illegal reflection" warning (CLJ-2066) on jdk >= 1.9
>>
>> Thanks to @MichaelBlume and all data.xml contributors!
>>
>> -- 
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with 
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 

Re: [ANN] data.xml 0.2.0-alpha5

[Herwig Hochleitner]

2017-11-14 4:03 GMT+01:00 Alan Thompson :

> I seem to still be getting the JDK 1.9 reflection warning:
>
>
> ~/tupelo > grep data.xml project.clj
> [org.clojure/data.xml "0.2.0-alpha5"]
>
> > lein test
> lein test tst.tupelo._bootstrap
>
> -
>Clojure 1.9.0-RC1Java 9.0.1
> -
>
> lein test tst.tupelo.array
>
> lein test tst.tupelo.async
>
> lein test tst.tupelo.dev
>
> lein test tst.tupelo.forest
>
> lein test tst.tupelo.forest-examples
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by clojure.lang.Reflector
> (file:/home/alan/.m2/repository/org/clojure/clojure/1.9.0-RC1/clojure-1.9.0-RC1.jar)
> to method com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.
> parse(org.xml.sax.InputSource,org.xml.sax.helpers.DefaultHandler)
> WARNING: Please consider reporting this to the maintainers of
> clojure.lang.Reflector
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> 
>
>
Hm, that's not showing up in the test suite:
https://build.clojure.org/job/data.xml-test-matrix/344/CLOJURE_VERSION=1.9.0-RC1,jdk=Open%20JDK%209%20with%20Eclipse%20Open%20J9/console

Might this warning only be occurring on oracle jdk?

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [ANN] data.xml 0.2.0-alpha5

[Alan Thompson]

I seem to still be getting the JDK 1.9 reflection warning:


~/tupelo > grep data.xml project.clj
[org.clojure/data.xml "0.2.0-alpha5"]

> lein test
lein test tst.tupelo._bootstrap

-
   Clojure 1.9.0-RC1Java 9.0.1
-

lein test tst.tupelo.array

lein test tst.tupelo.async

lein test tst.tupelo.dev

lein test tst.tupelo.forest

lein test tst.tupelo.forest-examples
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by clojure.lang.Reflector
(file:/home/alan/.m2/repository/org/clojure/clojure/1.9.0-RC1/clojure-1.9.0-RC1.jar)
to method
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(org.xml.sax.InputSource,org.xml.sax.helpers.DefaultHandler)
WARNING: Please consider reporting this to the maintainers of
clojure.lang.Reflector
WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations
WARNING: All illegal access operations will be denied in a future release





On Mon, Nov 13, 2017 at 3:47 PM, Herwig Hochleitner 
wrote:

> data.xml is a Clojure contrib library that parses and emits XML.
>
> Github: https://github.com/clojure/data.xml
> Changelog: https://github.com/clojure/data.xml/blob/master/CHANGES.md
>
> Information on updating the dependency is here
> .
>
> 0.2.0-alpha5 fixes a bug with emitting attributes in the builtin `xml:`
> namespace. In the process, there was a lot of clean-up work, removing
> various partial implementations of the recently introduced pu-map.
>
> Michael Blume got rid of reflection warnings. This should also remove the
> "illegal reflection" warning (CLJ-2066) on jdk >= 1.9
>
> Thanks to @MichaelBlume and all data.xml contributors!
>
> --
> You received this message because you are subscribed to the Google
> Groups "Clojure" group.
> To post to this group, send email to clojure@googlegroups.com
> Note that posts from new members are moderated - please be patient with
> your first post.
> To unsubscribe from this group, send email to
> clojure+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/clojure?hl=en
> ---
> You received this message because you are subscribed to the Google Groups
> "Clojure" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clojure+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[ANN] data.xml 0.2.0-alpha5

[Herwig Hochleitner]

data.xml is a Clojure contrib library that parses and emits XML.

Github: https://github.com/clojure/data.xml
Changelog: https://github.com/clojure/data.xml/blob/master/CHANGES.md

Information on updating the dependency is here
.

0.2.0-alpha5 fixes a bug with emitting attributes in the builtin `xml:`
namespace. In the process, there was a lot of clean-up work, removing
various partial implementations of the recently introduced pu-map.

Michael Blume got rid of reflection warnings. This should also remove the
"illegal reflection" warning (CLJ-2066) on jdk >= 1.9

Thanks to @MichaelBlume and all data.xml contributors!

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.