dustymabe commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
oh ok, so we're saying that the pungi override of repos doesn't work with the
change we made yesterday. got it.
``
To reply, visit the link below or just reply to
dustymabe commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
i'm pretty sure pungi already has support for overriding the repos.
Example
puiterwijk commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
Oh, yeah, I totally agree with that when Pungi can override ref, that's way
nicer (I would not even say "a bit").
``
To reply, visit the link below or just reply to
walters commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
Yeah it's fine, again I'm not objecting. But I thought what we had with
fedmsg-atomic-composer before was a bit nicer in that it overrode both the
`ref` and the
puiterwijk commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
The problem with Pungi's editing of "repos" in this downstream file is that, as
per documentation, lists get appended. So given that the base already had repos
in
puiterwijk commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
@walters And that is exactly what Pungi does.
Unfortunately, the problem is that right now, Pungi does not allow me to
override the ref, and that is what I need
walters commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
I'm not *opposed* to this but...again the reason I chose JSON was *precisely*
so that tools like pungi or whatever could easily override the `repos` field
dynamically.
ausil merged a pull-request against the project: `fedora-atomic` that you are
following.
Merged pull-request:
``
Make the list of repos empty in the default inherit chain
``
https://pagure.io/fedora-atomic/pull-request/90
___
cloud mailing list --
puiterwijk commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
I've confirmed that with this change, the "repos" field in the updates-*.json
files takes effect as expected.
``
To reply, visit the link below or just reply to this
puiterwijk commented on the pull-request: `Make the list of repos empty in the
default inherit chain` that you are following:
``
This basically moves the bulk of the tree definition to a -base, and just the
repos back to the fedora-atomic-host.json.
The reason for this is that this way, if
puiterwijk opened a new pull-request against the project: `fedora-atomic` that
you are following:
``
Make the list of repos empty in the default inherit chain
``
To reply, visit the link below or just reply to this email
https://pagure.io/fedora-atomic/pull-request/90
11 matches
Mail list logo
