Review: Approve continuous-integration
PASSED: Continuous integration, rev:227566642f525130d1dc1ac05c9bb3b56043cfa2
https://jenkins.ubuntu.com/server/job/cloud-init-ci/441/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/441
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:d2abad2ecf83e73590991f0bd004d8d4747b4fdb
https://jenkins.ubuntu.com/server/job/cloud-init-ci/440/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/440/console
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:4ce9ca112fbaa94f8df9005d1e82469ec2bd7065
https://jenkins.ubuntu.com/server/job/cloud-init-ci/439/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/439/console
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index b9458ff..9dc9157 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -319,7 +321,11 @@ class
* Source Package: cloud-init
* Version: 0.7.9-1538-g0a448dd-0ubuntu1+1385~trunk~ubuntu16.10.1
* Architecture: amd64
* Archive: ~cloud-init-dev/ubuntu/daily
* Component: main
* State: Failed to build
* Duration: 2 minutes
* Build Log:
* Source Package: cloud-init
* Version: 0.7.9-1538-g0a448dd-0ubuntu1+1438~trunk~ubuntu17.04.1
* Architecture: amd64
* Archive: ~cloud-init-dev/ubuntu/daily
* Component: main
* State: Failed to build
* Duration: 2 minutes
* Build Log:
* Source Package: cloud-init
* Version: 0.7.9-1538-g0a448dd-0ubuntu1+1441~trunk~ubuntu17.10.1
* Architecture: amd64
* Archive: ~cloud-init-dev/ubuntu/daily
* Component: main
* State: Failed to build
* Duration: 2 minutes
* Build Log:
* Source Package: cloud-init
* Version: 0.7.9-1538-g0a448dd-0ubuntu1+1271~trunk~ubuntu16.04.1
* Architecture: amd64
* Archive: ~cloud-init-dev/ubuntu/daily
* Component: main
* State: Failed to build
* Duration: 1 minute
* Build Log:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:48bf21bcb6046f1a2d1d029d286dcbe9eaf4f62e
https://jenkins.ubuntu.com/server/job/cloud-init-ci/438/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/438
SUCCESS:
looks much better thanks for this. minor inlines below
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index db3c357..ef000ae 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,6 +670,125 @@ class
The proposal to merge ~akaris/cloud-init:bug1679817-c into cloud-init:master
has been updated.
Status: Superseded => Merged
For more details, see:
https://code.launchpad.net/~akaris/cloud-init/+git/cloud-init/+merge/324195
--
Your team cloud-init commiters is requested to review the
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:704339ebcc50fde557cdf4885242e9eda7d0dc24
https://jenkins.ubuntu.com/server/job/cloud-init-ci/433/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/433/console
https://gist.github.com/smoser/a5435f49b61e2ae45c367bbb266bfac3
Add DI_DMI_CHASSIS_ASSET_TAG to _print_info in tools/ds-identify.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index b9458ff..9dc9157 100644
> ---
I have only one comment, and i'm fine with it as it is.
Could we put the main into cloudinit/config/schema.py ?
Then it would be executable on any system with cloud-init as:
python3 -m cloudinit.config.schema
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324640
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:bd9b28377d36741e31ea5ce843e62e85a6c96c61
https://jenkins.ubuntu.com/server/job/cloud-init-ci/432/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/432/console
Chad Smith has proposed merging ~chad.smith/cloud-init:azure-di-id-asset-tag
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324875
azure: ds-identify and
Review: Approve continuous-integration
PASSED: Continuous integration, rev:a2472853a66847a90b2e6892e3a22733518dbc8c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/431/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/431
SUCCESS:
17 matches
Mail list logo