Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ci-deps into cloud-init:master

2017-06-12 Thread Chad Smith
@scott I think I've addressed all comments here Diff comments: > diff --git a/packages/pkg-deps.json b/packages/pkg-deps.json > new file mode 100644 > index 000..2100ec7 > --- /dev/null > +++ b/packages/pkg-deps.json > @@ -0,0 +1,84 @@ > +{ > + "debian" : { > + "build-requires" : [

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master

2017-06-12 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master has been updated. Commit Message changed to: systemd: make cloud-final.service run before apt daily services. This changes all cloud-init systemd units to run 'Before' the apt processes that run daily and

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master

2017-06-12 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master has been updated. Commit Message changed to: systemd: make cloud-final.service run before apt daily services. This is really just a work around for apt. The solution here is to cause

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master

2017-06-12 Thread Steve Langasek
Review: Needs Information Would it make more sense logically to be Before=apt-daily.service (the thing that actually takes the conflicting lock), rather than Before=apt-daily.timer? I don't agree with characterizing this as a "workaround", because even if we had perfect handling of apt locks,

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master

2017-06-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/1693361-apt-get-locks into cloud-init:master. Commit message: systemd: make cloud-final.service run before apt daily services. This is really just a work around for apt. The solution here is to cause cloud-init-final.service to run Before

Re: [Cloud-init-dev] [Merge] ~ajorgens/cloud-init:pipe-cat into cloud-init:master

2017-06-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c97434e6c94690a0df292a70fd5ed6f5f0a389fa https://jenkins.ubuntu.com/server/job/cloud-init-ci/517/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/517 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~ajorgens/cloud-init:fix-gratuitous-templating into cloud-init:master

2017-06-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:657157dd172275b73b06816b5fc14df904754ae8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/516/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/516 SUCCESS:

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:schema-autodoc into cloud-init:master

2017-06-12 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:schema-autodoc into cloud-init:master. Commit message: docs: Automatically generate module docs form schema attribute if present We have started adding jsonschema defintions for cloudconfig modules (cc_ntp). This branch allows us render

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:schema-autodoc into cloud-init:master

2017-06-12 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:schema-autodoc into cloud-init:master has been updated. Commit Message changed to: docs: Automatically generate module docs form schema attribute if present We have started adding jsonschema defintions for cloudconfig modules (cc_ntp). This branch

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ci-deps into cloud-init:master

2017-06-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:0885377d86d1038d2e50b0dda5f692ba0edb https://jenkins.ubuntu.com/server/job/cloud-init-ci/512/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/512 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~redriver/cloud-init:fix-mount-issue-for-frbsd-on-Azure into cloud-init:master

2017-06-12 Thread Scott Moser
Hi, So I think the basic idea here is to attempt to mount the cdrom to verify that there is in fact a cdrom. Thats not an entirely bad idea, but it seems like it might be sufficient to either: a.) always add 'dev/cd0' on freebsd and let the code in get_data just attempt to mount, which means

Re: [Cloud-init-dev] [Merge] ~b1sandmann/cloud-init:fix-hostnames-for-suse into cloud-init:master

2017-06-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:6cf2c094e038e7f2e6c185a463e9d95767075a64 https://jenkins.ubuntu.com/server/job/cloud-init-ci/511/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/511 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master

2017-06-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:3a2b706697ddc21d8ef2649f5a350da74cc920ef https://jenkins.ubuntu.com/server/job/cloud-init-ci/510/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/510 SUCCESS:

[Cloud-init-dev] [Merge] ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master

2017-06-12 Thread Jens Sandmann
The proposal to merge ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master has been updated. Description changed to: The comments in the debian template file of /etc/hosts still pointed to a general template file instead of the debian one. Fixes bug 1606406 For more details, see:

[Cloud-init-dev] [Merge] ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master

2017-06-12 Thread Jens Sandmann
Jens Sandmann has proposed merging ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325478 The comments in the debian

[Cloud-init-dev] [Merge] ~b1sandmann/cloud-init:fix-hostnames-for-suse into cloud-init:master

2017-06-12 Thread Jens Sandmann
Jens Sandmann has proposed merging ~b1sandmann/cloud-init:fix-hostnames-for-suse into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325476 Add the hostname and fully