chad thanks for review. i'll get these fixes.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/pregen-locale into cloud-init:master.
_
why did you have to add mock to tox's pylint entries ?
also some inline.
this does look really nice though.
thank you.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..5a4a232 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__ini
Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos8 into
cloud-init:master.
Commit message:
sysconfig: use MACADDR on bonds/bridges to configure mac_address
Previously, sysconfig rendered HWADDR for all interface types, but
that value is only used to identify physical devi
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327836
has
sysconfig: enable mtu set per subnet, including ipv6 mtu
and then
net: eni route rendering missed ipv6 default route config
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
Your team
The proposal to merge ~smoser/cloud-init:feature/curtin-centos7 into
cloud-init:master has been updated.
Commit Message changed to:
I plan to squash the
tests: add tests for mtu for eni, netplan and sysconfig.
commit into
sysconfig: enable mtu set per subnet, including ipv6 mtu
and then just
Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos7 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1701097 in cloud-init: "eni rendering of ipv6 gateways fails"
https://bugs.launchpad.net/cloud-init/+bug/1701097
B
Diff comments:
> diff --git a/tests/unittests/test_distros/test_debian.py
> b/tests/unittests/test_distros/test_debian.py
> new file mode 100644
> index 000..bd7721c
> --- /dev/null
> +++ b/tests/unittests/test_distros/test_debian.py
> @@ -0,0 +1,70 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/tests/unittests/test_distros/test_debian.py
> b/tests/unittests/test_distros/test_debian.py
> new file mode 100644
> index 000..bd7721c
> --- /dev/null
> +++ b/tests/unittests/test_distros/test_debian.py
> @@ -0,0 +1,70 @@
> +# This file is part of cloud-init.
Review: Approve continuous-integration
PASSED: Continuous integration, rev:0b3d738c6230209a1cd2e1b84aaa18f657e0e7aa
https://jenkins.ubuntu.com/server/job/cloud-init-ci/67/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
sysconfig: handle manual type subnets
is at
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327828
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-
The proposal to merge ~smoser/cloud-init:feature/curtin-centos6 into
cloud-init:master has been updated.
Commit Message changed to:
sysconfig: handle manual type subnets
Implement manual control for sysconfig by using ONBOOT=N. This
allows an interface to be configured but not brought up.
Note
Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos6 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1687725 in cloud-init: "sysconfig render does not support type manual
subnets"
https://bugs.launchpad.net/cloud-ini
The proposal to merge ~smoser/cloud-init:feature/curtin-centos6 into
cloud-init:master has been updated.
Commit Message changed to:
sysconfig: handle manual type subnets
Implement manual control for sysconfig by using ONBOOT=N. This
allows an interface to be configured but not brought up.
LP:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:a3692fcda19267d6d63b0317cdfb40d6df8b08ed
https://jenkins.ubuntu.com/server/job/cloud-init-ci/64/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..5a4a232 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -77,7 +78,7 @@ def read_sys_net_int(iface, field):
> return None
> try:
> return int
merge for
sysconfig: fix ipv6 gateway routes
at
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327828
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/
Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos5 into
cloud-init:master.
Commit message:
sysconfig: fix ipv6 gateway routes
Currently only the subnet is checked for 'ipv6' setting, however, the
routes array may include a mix of v4 or v6 configurations, in particular,
th
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Description changed to:
cloudinit.net: add initialize_network_device function and unittest.
This is not yet called, but will be called in a subsequent Ec2-related branch
to manu
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Commit Message changed to:
cloudinit.net: add initialize_network_device function and unittests
This is not yet called, but will be called in a subsequent Ec2-related branch
to m
Chad Smith has proposed merging
~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
cloudinit.net: add init
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:5f364ce26a6d5544718ec5e961d3d0a3cdb75bae
https://jenkins.ubuntu.com/server/job/cloud-init-ci/61/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenkin
Review: Approve continuous-integration
PASSED: Continuous integration, rev:50912bf294eced2b825c7ed93ff9be98b43feda3
https://jenkins.ubuntu.com/server/job/cloud-init-ci/60/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
i plan on adding a vlan and a simple bridge test
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327821
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master.
__
merge for your
Fix sysconfig rendering of virtual interfaces with network configurations
is up at
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327821
i plan on adding a vlan and a simple bridge test.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+m
The proposal to merge ~smoser/cloud-init:feature/curtin-centos4 into
cloud-init:master has been updated.
Commit Message changed to:
sysconfig: fix rendering of bond, bridge and vlan types.
Previously, virtual types (bond, bridge, vlan) were almost completely broken.
They would not get any netwo
Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos4 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1695092 in cloud-init: "sysconfig only applies subnet/route config to
physical interfaces"
https://bugs.launchpad.n
26 matches
Mail list logo
