Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:137c2881ed2d330f9b2f26a267680bbe2f945149 https://jenkins.ubuntu.com/server/job/cloud-init-ci/116/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:a1268952438c26bb949b7799019b1a8fbb1fe6e6 https://jenkins.ubuntu.com/server/job/cloud-init-ci/114/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 46cb9c8..d38ea8b 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -233,15 +231,24 @@ def generate_fallback_config(blacklist_drivers=None, > config_driver=None): > if

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

theres nothing huge in my comments. thanks. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 46cb9c8..d38ea8b 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -175,12 +175,10 @@ def is_disabled_cfg(cfg): > return

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:f08dc1ea917cbd86a5ee4ab9e343800a6d904104 https://jenkins.ubuntu.com/server/job/cloud-init-ci/113/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/get_by_mac_use_get_interfaces into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:9d923c1ab9c4556b980509513ece4a414269b5b9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/112/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Diff comments: > diff --git a/cloudinit/sources/DataSourceEc2.py > b/cloudinit/sources/DataSourceEc2.py > index 4ec9592..ae0fe26 100644 > --- a/cloudinit/sources/DataSourceEc2.py > +++ b/cloudinit/sources/DataSourceEc2.py > @@ -73,21 +77,25 @@ class DataSourceEc2(sources.DataSource): >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py > new file mode 100644 > index 000..4d59bd0 > --- /dev/null > +++ b/cloudinit/net/dhcp.py > @@ -0,0 +1,118 @@ > +# Copyright (C) 2017 Canonical Ltd. > +# > +# Author: Chad Smith > +# > +#

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into cloud-init:master

Thanks for the review, I'll fix the issues you raised and push in an update. Diff comments: > diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py > index 31ed64e..0b92a40 100644 > --- a/cloudinit/config/cc_ntp.py > +++ b/cloudinit/config/cc_ntp.py > @@ -185,19 +217,25 @@ def

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/get_by_mac_use_get_interfaces into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:cleanup/get_by_mac_use_get_interfaces into cloud-init:master. Commit message: net: Reduce duplicate code. Have get_interfaces_by_mac use get_interfaces. get_interfaces_by_mac and get_interfaces just looked much alike. This makes

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into cloud-init:master

some small things. i assume you were as much trying to avoid test changes as anything else, but the defaults we have there seem simplistic. Diff comments: > diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py > index 31ed64e..0b92a40 100644 > --- a/cloudinit/config/cc_ntp.py >