My comments
there is a lot here, as you said.
* generally the test harness changes could be separated.
* I think access to the platform and os info in the test cases is good.
* I dont think the validation of /run/cloud-init/instance-data.json needs to
be Snap specific at all, we should
Review: Approve continuous-integration
PASSED: Continuous integration, rev:d68942b90ac4c18e9763563c288d436deed18456
https://jenkins.ubuntu.com/server/job/cloud-init-ci/826/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/tests/cloud_tests/testcases/modules/snap.py
> b/tests/cloud_tests/testcases/modules/snap.py
> new file mode 100644
> index 000..7120e3f
> --- /dev/null
> +++ b/tests/cloud_tests/testcases/modules/snap.py
> @@ -0,0 +1,132 @@
> +# This file is part of
Review: Approve continuous-integration
PASSED: Continuous integration, rev:ac9bb942577352b6e42c0cfd2c9571955fd295a8
https://jenkins.ubuntu.com/server/job/cloud-init-ci/825/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
See inline
Diff comments:
> diff --git a/tests/cloud_tests/testcases/modules/snap.py
> b/tests/cloud_tests/testcases/modules/snap.py
> new file mode 100644
> index 000..7120e3f
> --- /dev/null
> +++ b/tests/cloud_tests/testcases/modules/snap.py
> @@ -0,0 +1,132 @@
> +# This file is part of
some comments
Diff comments:
> diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py
> new file mode 100644
> index 000..1f94079
> --- /dev/null
> +++ b/cloudinit/config/cc_snap.py
> @@ -0,0 +1,275 @@
> +# Copyright (C) 2018 Canonical Ltd.
> +#
> +# This file is part of
Review: Approve continuous-integration
PASSED: Continuous integration, rev:27fd0d9a7ff489b4db0b7e7747ae6abaf3502f21
https://jenkins.ubuntu.com/server/job/cloud-init-ci/824/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~smoser/cloud-init:fix/test-run_tree-fixes into
cloud-init:master has been updated.
Commit Message changed to:
tests: fix run_tree and bddeb
This was broken probably when we inserted the ssh keys into Platform.
tox -e citest tree_run
and
tox -e citest bddeb
would
The proposal to merge ~smoser/cloud-init:fix/test-run_tree-fixes into
cloud-init:master has been updated.
Commit Message changed to:
tests: fix run_tree and bddeb
This was broken probably when we inserted the ssh keys into Platform.
tox -e citest tree_run
and
tox -e citest bddeb
would fail
Review: Approve continuous-integration
PASSED: Continuous integration, rev:2abbfe1faef809a56cbfeb6f5f5a50300e6e66c4
https://jenkins.ubuntu.com/server/job/cloud-init-ci/823/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Scott Moser has proposed merging ~smoser/cloud-init:fix/test-run_tree-fixes
into cloud-init:master.
Commit message:
tests: fix run_tree
This was broken probably when we inserted the ssh keys into Platform.
tox -e citest tree_run
would fail with KeyError in Platform.init due to lack of a
11 matches
Mail list logo
