Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Simon Poirier
Review: Approve +1 LGTM -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:feature/snap-module into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:a158a134a000178b180e016ba3dafd0633d5789f https://jenkins.ubuntu.com/server/job/cloud-init-ci/861/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..3210d6d > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,272 @@ > +# Copyright (C) 2018 Canonical Ltd. > +# > +# This file is part of cloud-init. See

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into cloud-init:master has been updated. Description changed to: see commit message. to test: 1. make a deb of this branch make deb; 2. create a container and install the deb lxc launch ubuntu-daily/bionic myb1; lxc file push

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into cloud-init:master has been updated. Description changed to: see commit message. to test: 1. make a deb of this branch make deb; 2. create a container and install the deb lxc launch ubuntu-daily/bionic myb1; lxc file push

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:fd11c422178edb75572ba0258369af3a074f6b3a https://jenkins.ubuntu.com/server/job/cloud-init-ci/858/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Simon Poirier
Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..3210d6d > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,272 @@ > +# Copyright (C) 2018 Canonical Ltd. > +# > +# This file is part of cloud-init. See

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:357e9a9919e45b7455259f55db157f50859b0b28 https://jenkins.ubuntu.com/server/job/cloud-init-ci/857/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:88980f346d0c926559ce2be207acc3da2f9c8e98 https://jenkins.ubuntu.com/server/job/cloud-init-ci/855/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:743df1cd81eb55d0fc2670fa480a44d9445b3f5a https://jenkins.ubuntu.com/server/job/cloud-init-ci/853/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/util-subp-accepts-string-cmd into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:47aea438bc0c278cf48bd9f56087e610ee1e96b0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/850/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/pylint-bionic-python into cloud-init:master

2018-03-15 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/pylint-bionic-python into cloud-init:master. Commit message: tests: Fix some warnings in tests that popped up with newer python. When running 'tox -e pylint' on a bionic system (python 3.6.4) I started seeing errors today like:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/util-subp-accepts-string-cmd into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:47aea438bc0c278cf48bd9f56087e610ee1e96b0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/849/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED: