Sorry for the delay, I've signed it now.
--
https://code.launchpad.net/~glasnt/cloud-init/+git/cloud-init/+merge/355287
Your team cloud-init commiters is requested to review the proposed merge of
~glasnt/cloud-init:topic/udevadm-sp into cloud-init:master.
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:f5914600a4e501acbe326597058e8de59af1193c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/368/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Thanks for the review. I've pushed some of your changes already. Doing
another round now.
Diff comments:
> diff --git a/cloudinit/cmd/devel/hotplug_hook.py
> b/cloudinit/cmd/devel/hotplug_hook.py
> new file mode 100644
> index 000..c24b1ff
> --- /dev/null
> +++
Diff comments:
> diff --git a/cloudinit/event.py b/cloudinit/event.py
> index f7b311f..77ce631 100644
> --- a/cloudinit/event.py
> +++ b/cloudinit/event.py
> @@ -2,16 +2,68 @@
>
> """Classes and functions related to event handling."""
>
> +from cloudinit import log as logging
> +from
i'm not all the way through, but here are some comments.
Diff comments:
> diff --git a/cloudinit/cmd/devel/hotplug_hook.py
> b/cloudinit/cmd/devel/hotplug_hook.py
> new file mode 100644
> index 000..c24b1ff
> --- /dev/null
> +++ b/cloudinit/cmd/devel/hotplug_hook.py
> @@ -0,0 +1,195 @@
>
Scott Moser has proposed merging
~raharper/cloud-init:feature/cloud-init-hotplug-handler into cloud-init:master.
Commit message:
wip fixme
Requested reviews:
cloud-init commiters (cloud-init-dev): review-wip
For more details, see:
The proposal to merge ~raharper/cloud-init:feature/cloud-init-hotplug-handler
into cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/356152
--
Your team cloud-init
7 matches
Mail list logo
