Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:047a654e9b7ca8dd8115aab2467c55f25ba312ca
https://jenkins.ubuntu.com/server/job/cloud-init-ci/762/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Commit message changed to:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Commit message changed to:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:db953566a9e6df91b4eaeebb813e45726136316c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/761/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:f6b0d9eb283917f4c2a5a5f863ad07c048346199
https://jenkins.ubuntu.com/server/job/cloud-init-ci/759/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..9a5ed43 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -536,24 +536,43 @@ def
Thanks! A couple of follow-ups, and a couple of nits I missed first time
around.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..9a5ed43 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..aef5d80 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -536,24 +536,35 @@ def
Hi,
I previously wrote a message to the mailing list, but without any response so
far, so I figured I'd write some more code and try this way. Happy about any
suggestions for improvements or guidance for other approaches.
Some notes right away:
- The "xenial" tox env does not work for me,
A first pass fixing most review comments is done.
One open point here is the extra_config overwriting user-data - it seems to me
that perhaps we should be using some other mechanism instead (my assumption was
that extra_config would be overwritten by user data - but that doesn't seem to
be the
The proposal to merge ~bitfehler/cloud-init:bitfehler/load_seed into
cloud-init:master has been updated.
Commit message changed to:
Support network-config in nocloud(-net) data source
This proposal adds a new function `load_seed` that can be used as a replacement
for `read_seeded` and
The proposal to merge ~bitfehler/cloud-init:bitfehler/load_seed into
cloud-init:master has been updated.
Commit message changed to:
Support network-config if nocloud(-net) data source
This proposal adds a new function `load_seed` that can be used as a replacement
for `read_seeded` and
Conrad Hoffmann has proposed merging ~bitfehler/cloud-init:bitfehler/load_seed
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~bitfehler/cloud-init/+git/cloud-init/+merge/369814
--
Your team cloud-init
13 matches
Mail list logo
