Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:networking into cloud-init:master

2019-07-24 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/sources/tests/test_oracle.py > b/cloudinit/sources/tests/test_oracle.py > index 97d6294..282382c 100644 > --- a/cloudinit/sources/tests/test_oracle.py > +++ b/cloudinit/sources/tests/test_oracle.py > @@ -145,15 +145,15 @@ class

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:networking into cloud-init:master

2019-07-24 Thread Ryan Harper
Nice clean-up. One question inline around the mock used, otherwise fine. Diff comments: > diff --git a/cloudinit/sources/tests/test_oracle.py > b/cloudinit/sources/tests/test_oracle.py > index 97d6294..282382c 100644 > --- a/cloudinit/sources/tests/test_oracle.py > +++