Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:wickedOrder into cloud-init:master

2019-09-25 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:338e528962ea1c817825e66d9119e51c3d3f6a71 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1178/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:whitespace into cloud-init:master

2019-09-25 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:5c6deb22d5c92c3902573fb15ba4fa813693a1f1 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1177/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:whitespace into cloud-init:master

2019-09-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:whitespace into cloud-init:master. Commit message: analyze/show: remove trailing space in output Requested reviews: cloud-init Commiters (cloud-init-dev) For more details, see:

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/sysconfig-skip-resolvconf-no-dns-config into cloud-init:master

2019-09-25 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:ac38c650c1b6cb9df4021786d772450470f17aff https://jenkins.ubuntu.com/server/job/cloud-init-ci/1176/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:wickedOrder into cloud-init:master

2019-09-25 Thread Ryan Harper
We've merged a fix for the CI failures in master, if you rebase, then CI will pass and we can land this. -- https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/373166 Your team cloud-init Commiters is requested to review the proposed merge of ~rjschwei/cloud-init:wickedOrder

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ci_fix into cloud-init:master

2019-09-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ci_fix into cloud-init:master. Commit message: .pylintrc: ignore missing enter_context members Pylint has started (incorrectly) warning about these in some test cases, so unbreak the build by ignoring them.

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Scott Moser
seems like filing an issue with astroid would be good thing to do. but other than that, i guess approve. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/373177 Your team cloud-init Commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Ryan Harper
>From Paride, ## [E1101(no-member), TestConfig.test_handle_with_no_growpart_entry] ## Instance of 'AbstractContextManager' has no 'enter_context' member This is caused by astroid 2.3.0 (released yesterday). It does not happen with Python 3.7, but with Python 3.6 it does. This could be because

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Ryan Harper
Here's the error: https://paste.ubuntu.com/p/fvYN3Pjg39/ -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/373177 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Ryan Harper
Yes, you can reproduce inside a bionic lxd container with master. just tox -e pylint -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/373177 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/pylint-no-member into

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Scott Moser
Did the bionic version of pylint fail? Really just curious what changed. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/373177 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:92227e036d36273b973b87cd94527d602498ed7f https://jenkins.ubuntu.com/server/job/cloud-init-ci/1171/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master

2019-09-25 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:fix/pylint-no-member into cloud-init:master. Commit message: pylintrc: add 'enter_context' to generated-members list On Bionic (python 3.6.8) we now see no-member errors on untouched code. This does not reproduce on Xenial (3.5) nor on Eoan