Robert Schweikert has proposed merging
~rjschwei/cloud-init:migrate-lp-to-github into cloud-init:master.
Commit message:
lp-to-git-users: adding rjschwei
Mapped from rjschwei
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net
Robert Schweikert has proposed merging ~rjschwei/cloud-init:findsysconfrender
into cloud-init:master.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1849378 in cloud-init: "sysconfig renderer not detected on SLE distros"
https://bugs.launchpad.net/
Robert Schweikert has proposed merging ~rjschwei/cloud-init:breakLink into
cloud-init:master.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/374517
If /etc/resolv.conf is a symlink break
Review: Approve
LGTM, thanks
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/373291
Your team cloud-init Commiters is requested to review the proposed merge of
~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into
cloud-init:master.
Robert Schweikert has proposed merging ~rjschwei/cloud-init:wickedOrder into
cloud-init:master.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/373166
Change the startup order. On SUSE
Fine with me, should address the problem.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/37
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/net-wait-for-interfaces into cloud-init:master.
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> index 0998392..5f6f2d8 100644
> --- a/cloudinit/net/sysconfig.py
> +++ b/cloudinit/net/sysconfig.py
> @@ -696,6 +696,14 @@ class Renderer(renderer.Renderer):
> if nm_conf_content:
>
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> index 0998392..5f6f2d8 100644
> --- a/cloudinit/net/sysconfig.py
> +++ b/cloudinit/net/sysconfig.py
> @@ -696,6 +696,14 @@ class Renderer(renderer.Renderer):
> if nm_conf_content:
>
Need help with the tests please. I couldn't figure out the right place to patch
out the udevadm settle call, i.e. cloudinit.util.udevadm_settle
Help is appreciated.
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/363571
Your team cloud-init commiters is requested to
> Is this something that we could write a unittest for relatively easily?
I had no idea how to test this. :( Usually I create tests, but in this case
couldn't figure it out.
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/363571
Your team cloud-init commiters is
Robert Schweikert has proposed merging ~rjschwei/cloud-init:triggerudev into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1817368 in cloud-init: "udev needs to be triggered if rules are written
to a new file"
https://bugs.lau
Robert Schweikert has proposed merging ~rjschwei/cloud-init:ifcfgipv6addrname
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1817230 in cloud-init: "SUSE network configuration for IPv6 static
addresses"
https://bugs.launchpad
Robert Schweikert has proposed merging ~rjschwei/cloud-init:noEmptyResolv into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1812853 in cloud-init: "should not write an "empty" resolve.conf file"
https://bugs.launchpad
> I think this should be OK if Centos images will ignore the STARTMODE variable,
> right? or that it's in-sync with the ONBOOT value?
I do not know the behavior of the tools on Centos when they see values they do
not understand. wicked simply ignores unknown stuff and one would hope that
Centos
Robert Schweikert has proposed merging ~rjschwei/cloud-init:serviceOrder into
cloud-init:master.
Commit message:
Network configuration file gets written when cloud-init.service
runs. Therefore this needs to run prior to the network tools (wicked)
Reference: lp#1799709
Requested reviews
Robert Schweikert has proposed merging ~rjschwei/cloud-init:activateNet into
cloud-init:master.
Commit message:
ONBOOT is not recognized on openSUSE and SUSE Linux Enterprise,
add the STARTMODE setting
Reference: lp#1799540
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more
Robert Schweikert has proposed merging ~rjschwei/cloud-init:suseDistroDetect
into cloud-init:master.
Commit message:
Reference: boo#427
openSUSE has changed the way the distribution is identified in os-release. This
addresses this change.
Requested reviews:
cloud-init commiters (cloud
Robert Schweikert has proposed merging ~rjschwei/cloud-init:systemdGenTmpl into
cloud-init:master.
Commit message:
The systemd generator used to generate the target file has a hard
coded path for the location of systemd. This path does not apply to all
distributions. Make the generator
Robert Schweikert has proposed merging ~rjschwei/cloud-init:handleUsrLocked
into cloud-init:master.
Commit message:
Handle a locked user
At present if the user exists and is already locked, either previous
user creation or user is created locked by default the lock action
exception
Robert Schweikert has proposed merging ~rjschwei/cloud-init:savePermFallback
into cloud-init:master.
Commit message:
Set a "save" default fall back, all distros will have root:root
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.lau
Robert Schweikert has proposed merging
~rjschwei/cloud-init:noHostBleedForMirrorTest into cloud-init:master.
Commit message:
At present the host network settings bleed into the test environment causing
the test test_handler_apt_source_v3 to fail if the host has a domain setting
other
On the topic of "missing command, but can pass test" raised by Ryan, I'd say we
should have some "documentation" in that outlines all external commands used.
We obviously have a list of required Python modules, I don't think we have a
list of external commands executed by subp. If they are
LGTM +1
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/349081
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:bug/1780481-fix-get-linux-distro into cloud-init:master.
___
Robert Schweikert has proposed merging ~rjschwei/cloud-init:suseSpec into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/346844
Addresses parts of lp#1092637
--
Your
Review: Approve
Thanks
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345786
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/1771382-ds-identify-ensure-sane-path into
cloud-init:master.
Review: Approve
LGTM
Thanks
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345630
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/opensuse-skip-on-httpretty-ssl-error into
cloud-init:master.
I looked around the testing code but couldn't figure out where and how I would
test this, thus this does not include any testing.
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/345377
Your team cloud-init commiters is requested to review the proposed merge of
Robert Schweikert has proposed merging ~rjschwei/cloud-init:emptyStageOK into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/345377
The user may create a config file
Robert Schweikert has proposed merging ~rjschwei/cloud-init:setPerm into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/337666
On SUSE distributions the neither the &quo
Robert Schweikert has proposed merging ~rjschwei/cloud-init:noLnxDistro into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1745235 in cloud-init: "distribution detection"
https://bugs.launchpad.net/cloud-init/+bug/1745235
For mo
Robert Schweikert has proposed merging ~rjschwei/cloud-init:iproute2tools into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/335406
Support iproute2 tools when older
Sorry, I think I am missing something in the bigger picture.
My goal was to add a basic test such that network configuration doesn't break
again. This is/was intended to be a crutch until we can get openSUSE/SUSE moved
to the sysconfig-renderer concept.
It is/was my impression that
Robert Schweikert has proposed merging ~rjschwei/cloud-init:baseNetConfTestSUSE
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Chad Smith (chad.smith)
Server Team CI bot (server-team-bot): continuous-integration
For more details, see:
https
You have been requested to review the proposed merge of
~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master.
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333772
It's a start a basic test for network configuration on openSUSE & SLES
Robert Schweikert has proposed merging ~rjschwei/cloud-init:chrony into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334992
Support chrony configuration (lp#1731619
Robert Schweikert has proposed merging ~rjschwei/cloud-init:btrfsResize into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334338
Resize of btrfs fails
Robert Schweikert has proposed merging ~rjschwei/cloud-init:reproducibleBuild
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334337
Make the package build
> Robert,
> This looks fine to me.
> We clearly do not have very good unit tests on the suse path.
Agreed
> Otherwise you'd have broken a test with your change.
>
> I do approve of the change, but can we get a test added?
Well the rub here is that I would really like to get the SUSE network
Robert Schweikert has proposed merging ~rjschwei/cloud-init:noManualNet into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334241
Related to 1733169
A network
Robert Schweikert has proposed merging ~rjschwei/cloud-init:systemdTmpl into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333940
As promised a while ago, I
Robert Schweikert has proposed merging ~rjschwei/cloud-init:netV1ToTranslate
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333904
Handle network configuration
Robert Schweikert has proposed merging ~rjschwei/cloud-init:baseNetConfTestSUSE
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333772
It's a start a basic test
Robert Schweikert has proposed merging ~rjschwei/cloud-init:ntpSUSE into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333575
Fix ntp configuration for openSUSE
The proposal to merge ~rjschwei/cloud-init:hostsTemplate into cloud-init:master
has been updated.
Commit Message changed to:
- Clarify doc around hosts file changes
- Fix etc/hosts setup for openSUSE and SLES
For more details, see:
https://bugs.launchpad.net/cloud-init/+bug/1731035
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333408
Your team cloud-init commiters is requested to review the proposed merge of
~rjschwei/cloud-init:hostsEmsg into cloud-init:master.
Correct no change in behavior for anyone. I just think it is potentially
confusing for someone reading the .service file.
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/331251
Your team cloud-init commiters is requested to review the proposed merge of
Diff comments:
> diff --git a/systemd/cloud-init-local.service.tmpl
> b/systemd/cloud-init-local.service.tmpl
> index ff9c644..870ccf1 100644
> --- a/systemd/cloud-init-local.service.tmpl
> +++ b/systemd/cloud-init-local.service.tmpl
> @@ -13,6 +13,10 @@ Before=shutdown.target
>
Robert Schweikert has proposed merging ~rjschwei/cloud-init:sysvinitSUSE into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1718649 in cloud-init: "sysV-init SUSE integration is broken"
https://bugs.launchpad.net/cloud-init/+b
Robert Schweikert has proposed merging ~rjschwei/cloud-init:taskLimit into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/330919
Set the TasksMax to inifinity, see [1
Diff comments:
> diff --git a/tools/read-dependencies b/tools/read-dependencies
> index 2a64868..08ef3bf 100755
> --- a/tools/read-dependencies
> +++ b/tools/read-dependencies
> @@ -35,7 +35,7 @@ DISTRO_INSTALL_PKG_CMD = {
> 'redhat': ['yum', 'install', '--assumeyes'],
> 'debian':
Yes, I think having whole numbers makes the most sense, and whatever the number
is it shold always pick the latest, i.e. opensuse42 would currently run 42.3
and sometime next year opensuse15 (yes the idea of increasing version numbers
got lost somewhere along he line) would then run the most
Robert Schweikert has proposed merging ~rjschwei/cloud-init:suseIntegrate into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/329616
Integrate support for openSUSE
Robert Schweikert has proposed merging ~rjschwei/cloud-init:dmidecodeAARCH64
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/309628
aarch64 supports dmidecode
Test case needs fixing, will resubmit
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/309627
Your team cloud init development team is requested to review the proposed merge
of ~rjschwei/cloud-init:dmidecodeAARCH64 into cloud-init:master.
Robert Schweikert has proposed merging ~rjschwei/cloud-init:dmidecodeAARCH64
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/309627
dmidecode is implemented
UNit test for this condition added, and pushed here.
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/305857
Your team cloud init development team is requested to review the proposed merge
of ~rjschwei/cloud-init:propertypecheck into cloud-init:master.
So kiwi exports the variable that is most likely causing the trouble
export BOOTABLE_FLAG="$(echo -ne '\x80')"
apparently cloud-init collects the environment settings and then runs them
through the decoder, which in turn blows up on 0x80.
--
The traceback I get with the unmodified code is as follows:
# /usr/bin/cloud-init init --local
failed run of stage init-local
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/cloudinit/cmd/main.py", line 521,
Robert Schweikert has proposed merging lp:~rjschwei/cloud-init/openSUSEsupport
into lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/openSUSEsupport/+merge/210899
Support openSUSE
59 matches
Mail list logo
