The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add devscripts dependency for make deb. Cleanup packages/bddeb.
Add a simple dependency check to "make deb" target for devscripts. Rework a bit
of the
Thanks Ryan for the review points, I know you are commenting on the Safeloader
proposal which is over here
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323088
so I'll copy them over to that proposal and comment over there.
--
Some thoughts on this:
1) we don't want users who apt install cloud-init to also pull down
python-devel, gcc and have to compile the extension, so please don't change
package deps here
2) this is currently an issue for the tox/venv environment, so let's focus on
how to enable the SafeLoader
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add devscripts dependency for make deb. Cleanup packages/bddeb.
Add a simple dependency check to "make deb" target for devscripts. Rework a bit
of the
Review: Approve continuous-integration
PASSED: Continuous integration, rev:8be60732fae6ae5eaae97f374079b1c63160187c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/269/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/269
SUCCESS:
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Description changed to:
make deb: Add dependency on devscripts for make deb and minor cleanup of
packages/bddeb script.
Add a simple dependency check to "make deb" target for devscripts.
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add dependency on devscripts for make deb and minor cleanup of
packages/bddeb script.
Add a simple dependency check to "make deb" target for devscripts.
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add dependency on devscripts for make deb and minor cleanup of
packages/bddeb script.
Add a simple dependency check to "make deb" target for devscripts.
8 matches
Mail list logo