I think I've addressed the review feedback, let me know what are the next steps.
--
https://code.launchpad.net/~pzakha/cloud-init/+git/cloud-init/+merge/367721
Your team cloud-init commiters is requested to review the proposed merge of
~pzakha/cloud-init:userdata into cloud-init:master.
Diff comments:
> diff --git a/cloudinit/config/cc_ssh.py b/cloudinit/config/cc_ssh.py
> index f8f7cb3..e1542ee 100755
> --- a/cloudinit/config/cc_ssh.py
> +++ b/cloudinit/config/cc_ssh.py
> @@ -182,8 +182,19 @@ def handle(_name, cfg, cloud, log, _args):
> disable_root = util.get_cfg_op
Thanks for the reviews.
Yes I understand that if the user really wants to access the system, they will
find a way to do so. The intent of this is to make it non-trivial. Your
reasoning is spot on.
Diff comments:
> diff --git a/cloudinit/stages.py b/cloudinit/stages.py
> index da7d349..94b3f0f
I'm not opposed to this in principal. But I'd like to warn that this is not
"drm". The end user can probably find a way of getting root on your image if
they really want. You'll just be making it more difficult to do so.
That said, I do understand the desire to not have a user "break" your su
Hi Pavel, thanks for the contribution to cloud-init! I'm flitting between
meetings, so I'm not able to assess whether these changes are broadly
appropriate. That said, I do have an inline comment on how the changes could
be expressed a little more concisely. I'll revisit this later today for
Pavel Zakharov has proposed merging ~pzakha/cloud-init:userdata into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~pzakha/cloud-init/+git/cloud-init/+merge/367721
This adds 2 new configurations to allow disabling
6 matches
Mail list logo
