Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master

2017-08-18 Thread Ryan Harper
Diff comments: > diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py > index abfb81f..b2904e8 100644 > --- a/cloudinit/distros/debian.py > +++ b/cloudinit/distros/debian.py > @@ -246,9 +250,17 @@ def apply_locale(locale, sys_path=LOCALE_CONF_FN, > keyname='LANG'): >

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master

2017-08-18 Thread Chad Smith
Looks good, just some inline nits and questions Diff comments: > diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py > index abfb81f..b2904e8 100644 > --- a/cloudinit/distros/debian.py > +++ b/cloudinit/distros/debian.py > @@ -246,9 +250,17 @@ def apply_locale(locale,

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master

2017-08-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:aaec147b763cefe35e9d9f246d502f27de59edd7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/161/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master

2017-08-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8fe47a4abc15c59579c5a7805ff409c4ec140563 https://jenkins.ubuntu.com/server/job/cloud-init-ci/159/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master

2017-08-16 Thread Ryan Harper
Current Ubuntu (and Debian) images already include the C.UTF-8 locale. Updating the default in cloud-init (for Ubuntu and Debian) means we can realize a non-zero speed up during boot. Building cloud-init from this branch, injecting it into an artful image and comparing time spent in

[Cloud-init-dev] [Merge] ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master

2017-08-16 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:default-lang-c-utf8 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/329152 distro: allow distro to specify a