Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c2e308ad4eca888acee9aeac704f6e3784708b4c https://jenkins.ubuntu.com/server/job/cloud-init-ci/196/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/196 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:895e007a51d093c2d2ccb6233d9cd153256e57d9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/195/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/195/console

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Scott Moser
Generally speaking, get_interfaces_by_mac was simply broken for any occurance of duplicate mac addresses. From that perspective, this is simply a fix. The reality was that the "last" nic (per os.listdir()) would be the one chosen, which is not even sorted() (unless /sys was returning a directory

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:78e4aae8ae72b9173e1aa578a7bcd5d3ac581cb9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/194/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/194 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Ryan Harper
Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > old mode 100755 > new mode 100644 > index 1cf98ef..ff358c6 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -358,6 +386,8 @@ def get_interfaces_by_mac(devs=None): > rais

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master. Commit message: Fix bug that resulted in an attempt to rename bonds or vlans. When cloud-init ran in the init stage (after networking had come up). A bug could occur where cloud-init would att

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

2017-03-31 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master has been updated. Commit Message changed to: Fix bug that resulted in an attempt to rename bonds or vlans. When cloud-init ran in the init stage (after networking had come up). A bug could occur where cl