Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master

2016-10-24 Thread Wesley Wiedenmeier
Diff comments: > diff --git a/cloudinit/util.py b/cloudinit/util.py > index eb3e589..b9c88c9 100644 > --- a/cloudinit/util.py > +++ b/cloudinit/util.py > @@ -286,6 +287,20 @@ class ProcessExecutionError(IOError): > if not hasattr(self, 'message'): > self.message = message

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master

2016-10-24 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/util.py b/cloudinit/util.py > index eb3e589..b9c88c9 100644 > --- a/cloudinit/util.py > +++ b/cloudinit/util.py > @@ -286,6 +287,20 @@ class ProcessExecutionError(IOError): > if not hasattr(self, 'message'): > self.message = message

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master

2016-10-19 Thread Wesley Wiedenmeier
This should be able to merge cleanly now -- https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/306731 Your team cloud init development team is requested to review the proposed merge of ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master

2016-10-19 Thread Ryan Harper
On Wed, Oct 19, 2016 at 9:09 AM, Scott Moser wrote: > Please rebase. > > Ryan, will your log analyzer handle this change? > Yes, the analyzer is primarily interested in the event 'start' and 'finish' messages; the log exceptions aren't utilized for event tracking. I'll

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master

2016-10-13 Thread Joshua Harlow
Diff comments: > diff --git a/tests/unittests/test_util.py b/tests/unittests/test_util.py > index fc6b9d4..f8d416c 100644 > --- a/tests/unittests/test_util.py > +++ b/tests/unittests/test_util.py > @@ -604,11 +604,70 @@ class TestSubp(helpers.TestCase): >