Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-06-14 Thread Scott Moser
Hi. I've marked this 'merged' as I think it is now in trunk under 76d58265e34851b78e952a7f275340863c90a9f5. If you disagree, please feel free to re-open. -- https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 Your team cloud-init commiters is requested to revie

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-06-14 Thread Scott Moser
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Status: Work in progress => Merged For more details, see: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 -- Your team cloud-init commite

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-05-24 Thread Scott Moser
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 -- Your team cloud-init c

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-05-24 Thread Scott Moser
I'm going to mark this 'work in progress'. Josh has integrated this branch and others into his merge proposal at https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136 . We do plan to pull that all soon. Thanks for your work, Wesley! -- https://code.launchpad.net/~wesle

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:7918b5cf3fdbfe8ca854f9c78c5c05c9ab2d1e64 https://jenkins.ubuntu.com/server/job/cloud-init-ci/134/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/134 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:b9f673fcc73a818cf30c963cd088f4dee7e34c49 https://jenkins.ubuntu.com/server/job/cloud-init-ci/118/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/118 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:1c55c8bb2a965cd95f33b1b464554048385eabda https://jenkins.ubuntu.com/server/job/cloud-init-ci/117/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/117 SUCCESS: htt

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-15 Thread Wesley Wiedenmeier
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Description changed to: integration-testing updates  - enable additional distros  - allow use of either pylxd 2.1.3 or 2.2.3    - detected at runtime during instance.execute()    -

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-15 Thread Wesley Wiedenmeier
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Description changed to: integration-testing updates  - enable additional distros  - allow use of either pylxd 2.1.3 or 2.2.3    - detected at runtime during instance.execute()    -

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-15 Thread Wesley Wiedenmeier
I've squashed the commit history for this branch together into a patch series, so it should be easier to review commit by commit now. -- https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 Your team cloud init development team is requested to review the propose

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-13 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:f28a848f23abce1c2630d63b4ad8879e884c4fdb https://jenkins.ubuntu.com/server/job/cloud-init-ci/111/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/111 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:9e3596dd6f481e42095b32f972acd6309e12ccb0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/108/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/108 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:bee10bde56a37eafcb61ebaa1f8db7143c35de37 https://jenkins.ubuntu.com/server/job/cloud-init-ci/107/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/107 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:cffc558b6ef2d98a5bdacf98be15f6946042fa68 https://jenkins.ubuntu.com/server/job/cloud-init-ci/106/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/106 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-11 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:1c3b07a8634f5b219b41f138ac016bfaccff4042 https://jenkins.ubuntu.com/server/job/cloud-init-ci/105/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/105 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-11 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c6e896b627e59d7ce8684dcc190d4adc018a https://jenkins.ubuntu.com/server/job/cloud-init-ci/104/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/104/console

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-07 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:bc332ca6b4d28e73efcd7adeb1854358a1395afa https://jenkins.ubuntu.com/server/job/cloud-init-ci/93/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/93 SUCCESS: https

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-03-06 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:b7d483f8dce139c688cd8e28b4195768365e7741 https://jenkins.ubuntu.com/server/job/cloud-init-ci/76/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/76 SUCCESS: https

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-02-11 Thread Wesley Wiedenmeier
Wesley Wiedenmeier has proposed merging ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master. Requested reviews: Joshua Powers (powersj) cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/clo

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-02-11 Thread Wesley Wiedenmeier
This branch should mostly be ready to merge in now. There is additonal work to be done on getting the cc_apt_configure issue resolved in debian jessie, and the hostnamectl issue resolved on centos70, but that can wait, as these are most likely not issues caused by the test suite. Support for pac

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-29 Thread Wesley Wiedenmeier
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 -- Your team cloud init d

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-28 Thread Wesley Wiedenmeier
> >> * where is the upstream bug that prevents 2.2 from working > >>correctly? > > > It was at https://github.com/lxc/pylxd/issues/209, but the fix has > > Thanks, please mention it in the code. Sure, I'll add a comment in there. > >> * i think we can live without 'alias: t'. > > > The '

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-27 Thread Scott Moser
>> * full chart of enabled/disabled at: http://goo.gl/q78sY8 >>this is a private url, not suitable for a commit message >>possibly we just move this into doc in cloud-init? > >I'll go ahead and pull this link out of the commit message. I have >been meaning to do some doc updates, I'll add

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-27 Thread Wesley Wiedenmeier
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Description changed to: integration-testing updates  - enable additional distros  - allow use of either pylxd 2.1.3 or 2.2    - detected at runtime during instance.execute()    - wh

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-26 Thread Wesley Wiedenmeier
> lots of comments... > Thanks for all the work here, we need to try to do things more > iteratively. I know we're still bringing this all up, but there > is just so much here that its almost impossible to review. Yeah this was definitely too large a merge, we just got stuck with lots of changes t

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-26 Thread Scott Moser
lots of comments... Thanks for all the work here, we need to try to do things more iteratively. I know we're still bringing this all up, but there is just so much here that its almost impossible to review. General: * please lets try to do smaller merge proposals, doing one set of things at a

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-24 Thread Scott Moser
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master has been updated. Description changed to: integration-testing updates  - enable additional distros    - full chart of enabled/disabled at: http://goo.gl/q78sY8  - allow use of either pylxd 2.1.3 or 2

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-18 Thread Wesley Wiedenmeier
> LGTM, with two minor comments below. Reusing images has really sped up > execution and printing the cloud-init version is great. Thanks. Yeah, re-using the images should help quite a bit with runtime. > Comment 1: > The warning messages about using pylxd < 2.2 [1]. There are far too many > mess

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-18 Thread Joshua Powers
Review: Approve LGTM, with two minor comments below. Reusing images has really sped up execution and printing the cloud-init version is great. I ran through the following tests: $ tox $ tox -e citest -- run -v -n zesty -t tests/cloud_tests/configs/modules/write_files.yaml $ tox -e citest_new_p

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-17 Thread Wesley Wiedenmeier
All distros will work on both pylxd 2.1.3 and pylxd 2.2, the only problem running with 2.1.3 is the lack of error handling, which makes debugging setup_image difficult when it isn't working. Not all of the new distros work correctly, centos66 will fail due to not having cloud-init in its repos,

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-17 Thread Joshua Powers
@wesley, per the commit message you enabled additional distros. It looks like wheezy, jessie and centros66, and centos70. Do these require the newer version of pylxd for running? Should they work as expected? Trying to understand how to test these. -- https://code.launchpad.net/~wesley-wiedenme

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-16 Thread Wesley Wiedenmeier
Wesley Wiedenmeier has proposed merging ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 int

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-16 Thread Wesley Wiedenmeier
This should be ready to merge and includes all changes from: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/314496 -- https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 Your team cloud init development team is requested to revi

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-09 Thread Wesley Wiedenmeier
This is blocked on pylxd: https://github.com/lxc/pylxd/issues/209 A fix for the pylxd bug is available at: https://github.com/lxc/pylxd/pull/211 -- https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218 Your team cloud init development team is requested to review

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-08 Thread Wesley Wiedenmeier
It looks like the remaining centos70 issue is not an error in the test suite or in cloud-init; its a systemd bug in the centos images from images.linuxcontainers.org. I haven't tested on official centos images yet, so its possible either that it is a bug in centos, in centos/lxd integration, or

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-06 Thread Wesley Wiedenmeier
Switching to polling in the image rather than with repeated calls to pylxd's execute() seems to have fixed the too many open files issue, although once the test suite is made to run in parallel this may become an issue again. Centos tests are not running smoothly yet because of what looks like a

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master

2017-01-05 Thread Wesley Wiedenmeier
There are 2 outstanding issues with releases that are now enabled: Debian Jessie encounteres errors with cc_apt_configure, even with no 'apt' config keys presented. This does not cause cloud-init to completely fail; however, the tests fail as they all check that cloud-init stages did not encounter