Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c3183e99372292155fd3f9a9124d015d8d9a34dd https://jenkins.ubuntu.com/server/job/cloud-init-ci/99/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-15 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/sources/DataSourceOpenStack.py > b/cloudinit/sources/DataSourceOpenStack.py > index 1a12a3f..1c803f4 100644 > --- a/cloudinit/sources/DataSourceOpenStack.py > +++ b/cloudinit/sources/DataSourceOpenStack.py > @@ -205,6 +212,20 @@ def

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-15 Thread Ryan Harper
Diff comments: > diff --git a/cloudinit/sources/DataSourceOpenStack.py > b/cloudinit/sources/DataSourceOpenStack.py > index 1a12a3f..1c803f4 100644 > --- a/cloudinit/sources/DataSourceOpenStack.py > +++ b/cloudinit/sources/DataSourceOpenStack.py > @@ -205,6 +212,20 @@ def

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-15 Thread Scott Moser
trivial suggestions. Diff comments: > diff --git a/cloudinit/util.py b/cloudinit/util.py > index 26a4112..40a3959 100644 > --- a/cloudinit/util.py > +++ b/cloudinit/util.py > @@ -2629,6 +2629,15 @@ def _call_dmidecode(key, dmidecode_path): > return None > > > +def is_x86(): can

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:760279fb794ee510f0bf778c1219bc4def0a15ca https://jenkins.ubuntu.com/server/job/cloud-init-ci/95/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-14 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:44caa4afd5810f34091d218638de35c0aa6aaf19 https://jenkins.ubuntu.com/server/job/cloud-init-ci/89/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-14 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2effe5c3a1d89c38e3890c2f275046354bfd1b98 https://jenkins.ubuntu.com/server/job/cloud-init-ci/88/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-14 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c84f6798829de3a5b6817057dbea4ba1bdf46081 https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-14 Thread Scott Moser
some minor things. Diff comments: > diff --git a/cloudinit/sources/DataSourceOpenStack.py > b/cloudinit/sources/DataSourceOpenStack.py > index 1a12a3f..e7b0b41 100644 > --- a/cloudinit/sources/DataSourceOpenStack.py > +++ b/cloudinit/sources/DataSourceOpenStack.py > @@ -205,6 +209,25 @@ def

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-14 Thread Ryan Harper
If not already done so, we should update the OpenStack datasource docs to indicate which product strings/chassis ids are used to positively identify OpenStack datasource on VMs and containers. Diff comments: > diff --git a/cloudinit/sources/DataSourceOpenStack.py >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-13 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:28a042285ad04512a03f611731b455a870c14961 https://jenkins.ubuntu.com/server/job/cloud-init-ci/80/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu