Review: Approve continuous-integration
PASSED: Continuous integration, rev:7c480f71a2016f9a727479a54a002d03ec24453f
https://jenkins.ubuntu.com/server/job/cloud-init-ci/94/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/94
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:312808680eb5484b112ef874bf13fe2fdac8515e
https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/87
FAILURE:
Diff comments:
> diff --git a/cloudinit/sources/helpers/vmware/imc/config.py
> b/cloudinit/sources/helpers/vmware/imc/config.py
> index d645c49..711dc0b 100644
> --- a/cloudinit/sources/helpers/vmware/imc/config.py
> +++ b/cloudinit/sources/helpers/vmware/imc/config.py
> @@ -28,11 +30,15 @@
> Please set a combined commit message ('Set commit message' above.
>
> Can you explain where you're going also?
> I'm concerned about adding more "vmware" paths for configuring things that are
> done elsewhere (or not elsewhere) in cloud-init. We'd like have consistent
> paths for doing things
Updated some formatting.
--
https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427
Your team cloud init development team is requested to review the proposed merge
of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master.
Thanks for the comments Joshua.
Updated the diff.
--
https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427
Your team cloud init development team is requested to review the proposed merge
of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master.
6 matches
Mail list logo