Re: [Cloud-init-dev] [Merge] ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master

2018-02-01 Thread Scott Moser
Tatiana, I'll get our c-i bot to test your branch, and pending success there, looks good! -- https://code.launchpad.net/~tlashchova/cloud-init/+git/cloud-init/+merge/337003 Your team cloud-init commiters is requested to review the proposed merge of ~tlashchova/cloud-init:fix-bug-add-unittest

Re: [Cloud-init-dev] [Merge] ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master

2018-02-01 Thread Tatiana Kholkina
> improve your commit message, just have a 'messag'e part as well as subject. > > Ie: >Do not write invalid keys to authorized_keys > >This fixes a bug where invalid keys would sneak into authorized_keys. Done --

Re: [Cloud-init-dev] [Merge] ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master

2018-02-01 Thread Scott Moser
improve your commit message, just have a 'messag'e part as well as subject. Ie: Do not write invalid keys to authorized_keys This fixes a bug where invalid keys would sneak into authorized_keys. Diff comments: > diff --git a/cloudinit/ssh_util.py b/cloudinit/ssh_util.py > index