Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

Seems ok, one change. resp = url_helper.readurl(url=url_map[mkey], headers=headers) Can u wrap this with a try: except IOError: block. Thanks -- https://code.launchpad.net/~jablonskis/cloud-init/add-gce-datasource/+merge/204464 Your team cloud init development team is requested to review the

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

Yep. I will push my changes tonight. Thanks! On 8 February 2014 20:35, Joshua Harlow harlo...@gmail.com wrote: Seems ok, one change. resp = url_helper.readurl(url=url_map[mkey], headers=headers) Can u wrap this with a try: except IOError: block. Thanks --

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

Just to let you know, I have pushed the suggested changes already. On 8 February 2014 20:39, Vaidas Jablonskis jablons...@gmail.com wrote: Yep. I will push my changes tonight. Thanks! On 8 February 2014 20:35, Joshua Harlow harlo...@gmail.com wrote: Seems ok, one change. resp =

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

Thanks, Can we also have some tests :) U should be able to use httpretty to simulate the gce datasource like is being used in: https://code.launchpad.net/~harlowja/cloud-init/ds-openstack/+merge/204390 (search for 'test_openstack.py' and for '_register_uris' for the mocking part). --

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

I will work on that. Thanks for the guidance! On 8 February 2014 21:19, Joshua Harlow harlo...@gmail.com wrote: Thanks, Can we also have some tests :) U should be able to use httpretty to simulate the gce datasource like is being used in: