Re: [Cloud-init-dev] [Merge] ~bbaude/cloud-init:azure_bounce into cloud-init:master

2017-03-20 Thread Joshua Powers
After adding commit 9040e78, this ran integration tests successfully: https://paste.ubuntu.com/24217659/ -- https://code.launchpad.net/~bbaude/cloud-init/+git/cloud-init/+merge/320411 Your team cloud init development team is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master

2017-03-20 Thread Scott Moser
The proposal to merge ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/320291 -- Your team cloud init development team

Re: [Cloud-init-dev] [Merge] ~bbaude/cloud-init:azure_bounce into cloud-init:master

2017-03-20 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:4e9065e46fa8bdad3e32ea00f3ede709bbd201d5 https://jenkins.ubuntu.com/server/job/cloud-init-ci/146/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/146 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master

2017-03-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1c1fc3a8841a85b86b51931c9f8058832ad3b00a https://jenkins.ubuntu.com/server/job/cloud-init-ci/145/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/145/console

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing-tmpdir into cloud-init:master

2017-03-20 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:d730a7cb5f4fa25331837d48910f5d192871223a https://jenkins.ubuntu.com/server/job/cloud-init-ci/141/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/141 SUCCESS:

[Cloud-init-dev] [Merge] ~bbaude/cloud-init:azure_bounce into cloud-init:master

2017-03-20 Thread Brent Baude
Brent Baude has proposed merging ~bbaude/cloud-init:azure_bounce into cloud-init:master. Requested reviews: Server Team CI bot (server-team-bot): continuous-integration cloud init development team (cloud-init-dev) For more details, see:

Re: [Cloud-init-dev] [Merge] ~bbaude/cloud-init:azure_bounce into cloud-init:master

2017-03-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:3392d841335cad4615381f274071729a9866e9a7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/142/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/142/console

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master

2017-03-20 Thread Scott Moser
i have some small comments. don't worry about fixing the 'handle_' comment, but i do worry about the confusion. Diff comments: > diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py > index 803ac74..22ae998 100755 > --- a/cloudinit/distros/__init__.py > +++

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master

2017-03-20 Thread Ryan Harper
Diff comments: > diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py > index 803ac74..22ae998 100755 > --- a/cloudinit/distros/__init__.py > +++ b/cloudinit/distros/__init__.py > @@ -73,7 +73,7 @@ class Distro(object): > > def _supported_write_network_config(self,

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing-tmpdir into cloud-init:master

2017-03-20 Thread Wesley Wiedenmeier
Wesley Wiedenmeier has proposed merging ~wesley-wiedenmeier/cloud-init:integration-testing-tmpdir into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see:

[Cloud-init-dev] [Merge] ~powersj/cloud-init:1674317_fix_is_file into cloud-init:master

2017-03-20 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:1674317_fix_is_file into cloud-init:master. Commit message: net: Fix incorrect call to isfile Previous commit 5beecdf introduced a regression by calling os.path.is_file, a non-existent function. This changes that call to use os.path.isfile.

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:1674317_fix_is_file into cloud-init:master

2017-03-20 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c82124dc89906cb833cbdaca43254238502e9155 https://jenkins.ubuntu.com/server/job/cloud-init-ci/143/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/143 SUCCESS:

[Cloud-init-dev] [Merge] ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master

2017-03-20 Thread Ryan Harper
The proposal to merge ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master has been updated. Description changed to: cloudinit.net: add network config v2 parsing and rendering Network configuration version 2 format is implemented in a package called netplan (nplan)[1]

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master

2017-03-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:9bcc80e67b77dbce265de68c11f5f90916988ea0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/144/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/144/console

[Cloud-init-dev] [Merge] ~powersj/cloud-init:1674317_fix_is_file into cloud-init:master

2017-03-20 Thread Scott Moser
The proposal to merge ~powersj/cloud-init:1674317_fix_is_file into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/320414 -- Your team cloud init development team is requested to