Joshua Powers has proposed merging ~powersj/cloud-init:fix-blank-line into
cloud-init:master.
Commit message:
tests: cleanup pycodestyle error of missing blank line
LP: #1692960
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1692960 in cloud-init: "tests:
Scott Moser has proposed merging ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
--
Your team cloud-init commiters is
The proposal to merge ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master has been updated.
Commit Message changed to:
flake8: move the pinned version of flake8 up to 3.3.0
This just moves flake8 and related tools up to newer versions and fixes the
complaints associated with that.
Review: Approve
+1 land it
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324490
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:fix-blank-line into cloud-init:master.
___
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -53,14 +53,12 @@ distros = ['centos', 'debian', 'fedora', 'opensuse',
> 'ubuntu']
>
>
> def
some responses in line. i'll fix some things too. thanks for review.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
>
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can
Given that these are all generally acceptable changes I'm going to pull this.
Even if its possible we'd find fallout of the hacking issue.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
some comments in line.
I'm generally in agreement here.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -53,14 +53,12 @@ distros = ['centos',
Review: Approve continuous-integration
PASSED: Continuous integration, rev:49c4eb85daa77cb20a027e3199a92e3dbc773f53
https://jenkins.ubuntu.com/server/job/cloud-init-ci/381/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/381
SUCCESS:
https://bugs.launchpad.net/hacking/+bug/1607942
is a 'hacking' upstream bug on versions.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/flake8-upgrade into
Review: Approve continuous-integration
PASSED: Continuous integration, rev:194e15a6785f695ed5d228fdf6601837df3fb781
https://jenkins.ubuntu.com/server/job/cloud-init-ci/384/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/384
SUCCESS:
Hm..
So after doing this I noticed that pep8 is still in my tox flake8 env and
wondered why.
$ pip check
hacking 0.13.0 has requirement flake8<2.6.0,>=2.5.4, but you have flake8 3.3.0.
hacking 0.13.0 has requirement mccabe==0.2.1, but you have mccabe 0.6.1.
hacking 0.13.0 has requirement
I expect :vi info in files (H102)
for H304, I dont have strong feelings. we could fix these.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/flake8-upgrade into
The proposal to merge ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master has been updated.
Commit Message changed to:
flake8: move the pinned version of flake8 up to 3.3.0
This just moves flake8 and related tools up to newer versions and fixes the
complaints associated with that.
The proposal to merge ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
--
Your team cloud-init commiters is requested to
for quick reference, H304 shows:
http://paste.ubuntu.com/24635484/
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/flake8-upgrade into cloud-init:master.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -69,18 +67,12 @@ def handle(name, cfg, cloud, log, _args):
> " but not a
Review: Approve
LGTM thank you for updating the versions as well.
The tip commands all pass, tox passes, and the versions all look to be good to
go.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed
Updated the test content to check that snapd is installed using dpkg output
rather than relying on --version output.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324430
Your team cloud-init commiters is requested to review the proposed merge of
Review: Approve continuous-integration
PASSED: Continuous integration, rev:2825a917e5fa130818c0d77219f32961b99a057f
https://jenkins.ubuntu.com/server/job/cloud-init-ci/385/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/385
SUCCESS:
Chad Smith has proposed merging ~chad.smith/cloud-init:cc-ntp-schema into
cloud-init:master with ~chad.smith/cloud-init:cc-ntp-testing as a prerequisite.
Commit message:
cc_ntp: Add schema definition and passive schema validation logging warnings.
cloud-config files are very flexible and
Review: Approve continuous-integration
PASSED: Continuous integration, rev:a4f3aab9cdc3c5b04c8df2ed768dca4a3cc06149
https://jenkins.ubuntu.com/server/job/cloud-init-ci/380/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/380
SUCCESS:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:768e7ed3a8ebddacd7112afccb94e8fe864bcdd0
https://jenkins.ubuntu.com/server/job/cloud-init-ci/387/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/387
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:15a8bc4dbb75ff9968c344cda907e0fd6ed3a0fd
https://jenkins.ubuntu.com/server/job/cloud-init-ci/386/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/386/console
Review: Approve continuous-integration
PASSED: Continuous integration, rev:29d0bb1cffd00ec3df0c2effd4a649af07390911
https://jenkins.ubuntu.com/server/job/cloud-init-ci/388/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/388
SUCCESS:
26 matches
Mail list logo
