[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1768600-utf8-in-user-data into cloud-init:master

2018-06-13 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/1768600-utf8-in-user-data into cloud-init:master has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/347727 -- Your team cloud-init commiters is requested

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1775371-non-utf8-in-proc-env into cloud-init:master

2018-06-13 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/util.py b/cloudinit/util.py > index d9b61cf..441d5f7 100644 > --- a/cloudinit/util.py > +++ b/cloudinit/util.py > @@ -2080,24 +2080,33 @@ def is_container(): > return False > > > -def get_proc_env(pid): > +def get_proc_env(pid, encoding='utf-8',

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1768600-utf8-in-user-data into cloud-init:master

2018-06-13 Thread Scott Moser
chad took this over at https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/347782 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/347727 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-13 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master has been updated. Description changed to: Jenkins failures which showcased this warning message

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-13 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master has been updated. Description changed to: detect_openstack function is basically logic adapted from ./tools/ds-identify for detecting OpenStack. Jenkins failures which

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-13 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:28a042285ad04512a03f611731b455a870c14961 https://jenkins.ubuntu.com/server/job/cloud-init-ci/80/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master

2018-06-13 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2 into cloud-init:master. Commit message: openstack: avoid unneeded metadata probe on non-openstack platforms OpenStack datasource is now discovered in init-local stage. In order to probe whether