so where would the logic of "apply if changed" be placed?
Diff comments:
> diff --git a/cloudinit/hotplug.py b/cloudinit/hotplug.py
> new file mode 100644
> index 000..c5ba1af
> --- /dev/null
> +++ b/cloudinit/hotplug.py
> @@ -0,0 +1,15 @@
> +# This file is part of cloud-init. See LICENSE
I'm not super happy with the Maintenance name. Maybe SystemEvent? Also, I
think we need other classes of Event types; DatasourceEvents
(METADATA_REFRESHED) or PlatformEvents; Maybe we'll be notified of a pending
instance migration, pending shutdown, etc.
Diff comments:
> diff --git
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:ca3b0d7c1a6fc23bbea29458855c6c9550ea08c4
https://jenkins.ubuntu.com/server/job/cloud-init-ci/84/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
The proposal to merge ~chad.smith/cloud-init:feature/maintain-network-on-boot
into cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/348000
--
Your team cloud-init
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:d99396dd52b69d3ee54beeaf97c99e23620b7a0c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/82/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAltCloud.py
> b/cloudinit/sources/DataSourceAltCloud.py
> index 24fd65f..cd6ab17 100644
> --- a/cloudinit/sources/DataSourceAltCloud.py
> +++ b/cloudinit/sources/DataSourceAltCloud.py
> @@ -114,7 +114,7 @@ class
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/maintain-network-on-boot into cloud-init:master.
Commit message:
work-in-progress Strawman for MaintenanceEvent discussion.
Base-level MaintenanceEvent class and DataSource.maintain_metadata behavior to
allow clearing cached
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/83/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
The proposal to merge ~louis/cloud-init:enable_Scaleway_network_config into
cloud-init:master has been updated.
Commit message changed to:
Scaleway: Add network configuration to the DataSource
DEP_NETWORK is removed since the network_config must
run at each boot.
Network is brought up early
Louis Bouchard has proposed merging
~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master.
Commit message:
Scaleway: Add network configuration to the DataSource
DEP_NETWORK is removed since the network_config must
run at each boot.
Network is brought up early
Branch fixed & force pushed.
--
https://code.launchpad.net/~louis/cloud-init/+git/cloud-init/+merge/347973
Your team cloud-init commiters is requested to review the proposed merge of
~louis/cloud-init:enable_Scaleway_network_config into cloud-init:master.
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:ff0c6a2a4805ee8abe5e753886aa74218aedcec0
https://jenkins.ubuntu.com/server/job/cloud-init-ci/81/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:0cede0e8ee836f150b6382fddc551735fbae52c2
https://jenkins.ubuntu.com/server/job/cloud-init-ci/86/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/cloudinit/config/cc_lxd.py b/cloudinit/config/cc_lxd.py
> index 09374d2..b6ee756 100644
> --- a/cloudinit/config/cc_lxd.py
> +++ b/cloudinit/config/cc_lxd.py
> @@ -251,4 +257,47 @@ def bridge_to_cmd(bridge_cfg):
>
> return cmd_create, cmd_attach
>
> +
>
Diff comments:
> diff --git a/cloudinit/config/cc_lxd.py b/cloudinit/config/cc_lxd.py
> index 09374d2..b6ee756 100644
> --- a/cloudinit/config/cc_lxd.py
> +++ b/cloudinit/config/cc_lxd.py
> @@ -251,4 +257,47 @@ def bridge_to_cmd(bridge_cfg):
>
> return cmd_create, cmd_attach
>
> +
>
If not already done so, we should update the OpenStack datasource docs to
indicate which product strings/chassis ids are used to positively identify
OpenStack datasource on VMs and containers.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOpenStack.py
>
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:c84f6798829de3a5b6817057dbea4ba1bdf46081
https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
some minor things.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOpenStack.py
> b/cloudinit/sources/DataSourceOpenStack.py
> index 1a12a3f..e7b0b41 100644
> --- a/cloudinit/sources/DataSourceOpenStack.py
> +++ b/cloudinit/sources/DataSourceOpenStack.py
> @@ -205,6 +209,25 @@ def
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c16f9104673e1e8a1fdaa024cc3511d5ad147c17
https://jenkins.ubuntu.com/server/job/cloud-init-ci/85/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Scott Moser has proposed merging
~smoser/cloud-init:fix/lxd-only-create-network-if-noexist into
cloud-init:master.
Commit message:
lxd: Delete lxdbr0 network if it exists and is to be created.
Newer versions (3.0.1+) of lxd create the 'lxdbr0' network when
'lxd init --auto' is invoked.
When
Diff comments:
> diff --git a/cloudinit/config/cc_lxd.py b/cloudinit/config/cc_lxd.py
> index 09374d2..b6ee756 100644
> --- a/cloudinit/config/cc_lxd.py
> +++ b/cloudinit/config/cc_lxd.py
> @@ -251,4 +257,47 @@ def bridge_to_cmd(bridge_cfg):
>
> return cmd_create, cmd_attach
>
> +
>
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:2effe5c3a1d89c38e3890c2f275046354bfd1b98
https://jenkins.ubuntu.com/server/job/cloud-init-ci/88/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:44caa4afd5810f34091d218638de35c0aa6aaf19
https://jenkins.ubuntu.com/server/job/cloud-init-ci/89/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
23 matches
Mail list logo
