> thanks for the well done bug report and merge proposal!
>
> Please add a test to the unfortunately long and difficult to follow
> tests/unittests/test_net.py .
>
Thanks, I did'nt find these tests in my first iteration.
I added tests in tests/unittests/test_datasource/test_configdrive.py and
te
Oh, I noticed now I missed the comment in code.
I will update this to check specifically for the values we expect and raise an
error for other cases.
--
https://code.launchpad.net/~harald-jensas/cloud-init/+git/cloud-init/+merge/373932
Your team cloud-init Commiters is requested to review the pr
* State: Failed to build
* Recipe: cloud-init-dev/cloud-init-daily-bionic
* Archive: ~cloud-init-dev/ubuntu/daily
* Distroseries: bionic
* Duration: 4 minutes
* Build Log:
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/2420914/+files/buildlog.txt.gz
* Upload Log:
* State: Failed to build
* Recipe: cloud-init-dev/cloud-init-daily-xenial
* Archive: ~cloud-init-dev/ubuntu/daily
* Distroseries: xenial
* Duration: 4 minutes
* Build Log:
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/2420921/+files/buildlog.txt.gz
* Upload Log:
* State: Failed to build
* Recipe: cloud-init-dev/cloud-init-daily-disco
* Archive: ~cloud-init-dev/ubuntu/daily
* Distroseries: disco
* Duration: 4 minutes
* Build Log:
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/2420919/+files/buildlog.txt.gz
* Upload Log:
*
Ryan Harper has proposed merging
~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master.
Commit message:
cloud_test/lxd: Retry container delete a few times
LXD integration tests fail sometimes due to failure to delete the
container, usually related to ZFS backend. This is
Review: Approve
LGTM
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043
Your team cloud-init Commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master.
___
I need to add a sleep after the failure
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043
Your team cloud-init Commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master.
_
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:c6bdca59c2b7afdf19b9bc7a4df8367584016627
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1206/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jen
Review: Approve
Right. In the usual failure mode retrying should work even without sleeping,
but it's way better to add a sleep(1) there.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043
Your team cloud-init Commiters is requested to review the proposed merge of
Review: Approve continuous-integration
PASSED: Continuous integration, rev:aaf0c0e11ed07b65d15f8759d907483561c40334
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1207/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
11 matches
Mail list logo