[Cloud-init-dev] [Merge] lp:~xnox/cloud-init/refactor-dev-root into lp:cloud-init

2015-05-26 Thread Dimitri John Ledkov
Dimitri John Ledkov has proposed merging lp:~xnox/cloud-init/refactor-dev-root into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~xnox/cloud-init/refactor-dev-root/+merge/260165 refactor rootdev_from_cmdline

Re: [Cloud-init-dev] [Merge] lp:~xnox/cloud-init/refactor-dev-root into lp:cloud-init

2015-05-26 Thread Dimitri John Ledkov
kernel takes last root= argument, as it does for all arguments. I'm matching logic, to what kernel will do. Some people misconfigure bootloader, yet cloud appends it's own things to the end of cmdline hence last root= argument should win. no need to bail inside container. it will not be on a

Re: [Cloud-init-dev] [Merge] lp:~xnox/cloud-init/refactor-dev-root into lp:cloud-init

2015-05-26 Thread Scott Moser
I dont think so. without something like lxcfs, the /proc/cmdline in the container is the host's /proc/cmdline. so that 'root=' (whether it be /dev/sda1 or LABEL=) is not destined for this container. with lxcfs, that might be different (hopefully it will be). But /proc/mountinfo is namepsaced,