Dan and I discussed some and both of us were not sure if sfdisk's sectors were
physical or logical sectors.
I did some testing with kvm and it turns out it uses logical sectors.
That unit is the same you'd get back from 'blockdev --getss' that value can
also be read from /sys/
see http://paste.
Diff comments:
> === modified file 'cloudinit/config/cc_disk_setup.py'
> --- cloudinit/config/cc_disk_setup.py 2015-07-22 19:14:33 +
> +++ cloudinit/config/cc_disk_setup.py 2015-10-19 14:33:26 +
> @@ -343,13 +345,16 @@
>
>
> def get_mbr_hdd_size(device):
> -size_cmd = [SFDISK_CM
some comments inline.
other thing.. it seems like it would make sense to partition assuming sectors
of 4096 bytes. just to ensure alignment or to round all partition sizes to 1MB
or even 4MB.
if the user has just given us such course grained data as percentage, it seems
we have some wiggle room
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp1460715
into lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1460715 in cloud-init: "MBR disk setup fails in wily because sfdisk no
longer accepts M as a valid unit"
https:
Unlike other providers, the Scaleway user-data API is restricted to privileged
ports (< 1024) to prevent non-root users accessing to it.
We added a new parameter to readurl to specify the requests session object, to
bind on a specific port.
--
https://code.launchpad.net/~edouardb/cloud-init/sca
edouardb has proposed merging lp:~edouardb/cloud-init/scaleway-datasource into
lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~edouardb/cloud-init/scaleway-datasource/+merge/274861
Add Datasource for Scaleway's
6 matches
Mail list logo
