Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:spacewalk into cloud-init:master

2016-07-26 Thread Ryan Harper
handler looks fine, comments in line. missing: doc/examples/cloud-config-spacewalk.txt Diff comments: > diff --git a/cloudinit/config/cc_spacewalk.py > b/cloudinit/config/cc_spacewalk.py > new file mode 100644 > index 000..d82cfbf > --- /dev/null > +++ b/cloudinit/config/cc_spacewalk.py >

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:spacewalk into cloud-init:master

2016-07-26 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:spacewalk into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301224 -- Your team cloud init development te

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/digitalocean into lp:cloud-init

2016-07-26 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:1262 https://server-team-jenkins.canonical.com/job/cloud-init-ci/3/ Executed test runs: SUCCESS: https://server-team-jenkins.canonical.com/job/cloud-init-ci/nodes=amd64/3 SUCCESS: https://server-team-jenkins.canon

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix-make-check into cloud-init:master

2016-07-26 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:fix-make-check into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/301176 Fix make check on master. -- Your

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/digitalocean into lp:cloud-init

2016-07-26 Thread Ryan Harper
The errors: flake8 runtests: commands[0] | /var/lib/jenkins/slaves/jenkins-slave-4/workspace/cloud-init-ci/nodes/amd64/cloud-init-ci-2/.tox/flake8/bin/python -m flake8 cloudinit/ tests/ tools/ cloudinit/sources/DataSourceDigitalOcean.py:23:1: H306 imports not in alphabetical order (cloudinit.uti

Re: [Cloud-init-dev] [Merge] ~larsks/cloud-init:feature/move-to-git into cloud-init:master

2016-07-26 Thread Lars Kellogg-Stedman
Diff comments: > diff --git a/README.rst b/README.rst > new file mode 100644 > index 000..e56e663 > --- /dev/null > +++ b/README.rst > @@ -0,0 +1,15 @@ > +Cloud-init > +== > + > +Cloud-init is the defacto multi-distribution package that handles > +early initialization of a cloud inst