Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master

2016-08-03 Thread Joshua Harlow
So https://review.openstack.org/#/c/350861 is the addition to pbr for the 'deb version' so this imho makes me lean towards using pbr vs this package, and using either over a custom hand rolled version calculation scheme. Because with a hand rolled scheme, I'll still need to be translating the ou

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/digitalocean into lp:cloud-init

2016-08-03 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1265 https://jenkins.ubuntu.com/server/job/cloud-init-ci/5/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=amd64/5/console FAILURE: https://jenkins.ubuntu.com/server/jo

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master

2016-08-03 Thread Joshua Harlow
I guess the only thing that I can think about that makes using these tools useful is that they can provide a consistent way of getting that version (instead of yet another one-off way of getting it); pbr also has the nice ability to generate a debian version string and a redhat version string, w

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:space into cloud-init:master

2016-08-03 Thread Scott Moser
some test needed. I'd suggest making 'handle' do very little other than call a helper that has sane function signatures. i'm fine with it in principle. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301731 Your team cloud init development team is requested to review t

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:newer-configobj into cloud-init:master

2016-08-03 Thread Scott Moser
if we declare this as minimum version, i think there is some imrpvoement to ConfigObj usage in cloudinit/config/cc_mcollective.py we had to do this: try: mcollective_config = ConfigObj(server_cfg, file_error=True) existed = True except IOError: LOG.debug("Did no

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/digitalocean into lp:cloud-init

2016-08-03 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1264 https://jenkins.ubuntu.com/server/job/cloud-init-ci/4/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=amd64/4/console FAILURE: https://jenkins.ubuntu.com/server/jo

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master

2016-08-03 Thread Scott Moser
This would be runtime dependency, right? i'd really rather not take that. I'm not opposed to this and woudl like version information to follow *some* standard. what i have now is just what comes out of git describe modified a bit. see tools/make-tarball # revname could be 0.7.5 or 0.7.5-NNN-gH