[Cloud-init-dev] [Merge] ~jbicha/cloud-init:master into cloud-init:master

2017-01-12 Thread Jeremy Bicha
Jeremy Bicha has proposed merging ~jbicha/cloud-init:master into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~jbicha/cloud-init/+git/cloud-init/+merge/314658 -- Your team cloud init development team is re

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel

2017-01-12 Thread noreply
The proposal to merge ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/314623 -- Your team cloud init development

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing-invocation-cleanup into cloud-init:master

2017-01-12 Thread Joshua Powers
Review: Approve LGTM Thanks for the changes! Ran the following successfully with no changes to timeouts: $ tox $ tox -e citest_tree_run $ tox -e citest -- tree_run -n zesty -t tests/cloud_tests/configs/modules/write_files.yaml $ python3 -m tests.cloud_tests tree_run -v -n zesty -t tests/cloud

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel

2017-01-12 Thread Scott Moser
comments addressed. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/314623 Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel. __

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel

2017-01-12 Thread Dan Watkins
Review: Needs Fixing Diff comments: > diff --git a/debian/update-grub-legacy-ec2 b/debian/update-grub-legacy-ec2 > index 19648f6..c7a5687 100755 > --- a/debian/update-grub-legacy-ec2 > +++ b/debian/update-grub-legacy-ec2 > @@ -1398,9 +1398,19 @@ fi > > > if ! type is_xen_kernel >/dev/null

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel

2017-01-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1379080 in cloud-init (Ubuntu): "update-grub-legacy-ec2 fails to detect xen kernel" htt