Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:55db93085c69157237cd0f948d75bf23deb9ca2f https://jenkins.ubuntu.com/server/job/cloud-init-ci/103/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/103 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:gitignore-tox-doc-html into cloud-init:master

2017-03-10 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:78c3eb04c953e0b6fe8f0753d928a2566807b20b https://jenkins.ubuntu.com/server/job/cloud-init-ci/102/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/102 SUCCESS: htt

[Cloud-init-dev] [Merge] ~powersj/cloud-init:gitignore-tox-doc-html into cloud-init:master

2017-03-10 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:gitignore-tox-doc-html into cloud-init:master. Commit message: gitignore: adding doc/rtd_html When running tox -e doc it produces the complete read the docs output and places it in doc/rtd_html. This is not ignored by git and shows up as unc

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:netconfig-v2-passthrough into cloud-init:master

2017-03-10 Thread Ryan Harper
Thanks for the review Diff comments: > diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py > index 48ccec8..f77b1e3 100644 > --- a/cloudinit/distros/debian.py > +++ b/cloudinit/distros/debian.py > @@ -38,11 +39,16 @@ ENI_HEADER = """# This file is generated from information >

[Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Joshua Powers
The proposal to merge ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master has been updated. Commit Message changed to: doc: add running via tox instructions for integration tests For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319617 -- Y

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Joshua Powers
I am fine with removing the dependency section, running via tox is much simpler anyway. Update made, only have the run via tox method now. -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319617 Your team cloud init development team is requested to review the proposed merg

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Scott Moser
thoughts ? disagree? Diff comments: > diff --git a/doc/rtd/topics/tests.rst b/doc/rtd/topics/tests.rst > index 00c63c6..c487867 100644 > --- a/doc/rtd/topics/tests.rst > +++ b/doc/rtd/topics/tests.rst > @@ -182,6 +182,18 @@ Executing tests has three options: > * ``verify`` given a directory of t

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:a020368d28759e95177bfa3906acee74e9fe5ea9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/101/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/101 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:netconfig-v2-passthrough into cloud-init:master

2017-03-10 Thread Scott Moser
comments inline. Diff comments: > diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py > index 48ccec8..f77b1e3 100644 > --- a/cloudinit/distros/debian.py > +++ b/cloudinit/distros/debian.py > @@ -38,11 +39,16 @@ ENI_HEADER = """# This file is generated from information > prov

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Joshua Powers
tox -e doc output: https://paste.ubuntu.com/24153451/ -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319617 Your team cloud init development team is requested to review the proposed merge of ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master. __

[Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master. Commit message: doc: add dependencies and tox instructions for integration tests Add instructions on how to run the cii tests via tox as well as the basic system dependencies for running the cii te

[Cloud-init-dev] [Merge] ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master

2017-03-10 Thread Joshua Powers
The proposal to merge ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master has been updated. Commit Message changed to: doc: add dependencies and tox instructions for integration tests Add instructions on how to run the cii tests via tox as well as the basic system dependencies for ru

[Cloud-init-dev] [Merge] ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master

2017-03-10 Thread Jeremy Melvin
The proposal to merge ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master has been updated. Commit Message changed to: Fix chef config module in omnibus install. Omnibus installation of chef was broken. LP: #1583837 For more details, see: https://code.launchpad.net/~jmelvin/cloud-i

Re: [Cloud-init-dev] [Merge] ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master

2017-03-10 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:429b168188dc8e5c14c83b56d6ad4cd138d5d966 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):

Re: [Cloud-init-dev] [Merge] ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master

2017-03-10 Thread Jeremy Melvin
Fix chef config module in omnibus install. Omnibus installation of chef was broken. LP: #1583837 -- https://code.launchpad.net/~jmelvin/cloud-init/+git/cloud-init/+merge/319612 Your team cloud init development team is requested to review the proposed merge of ~jmelvin/cloud-init:my-topic-bra

[Cloud-init-dev] [Merge] ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master

2017-03-10 Thread Jeremy Melvin
Jeremy Melvin has proposed merging ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1583837 in cloud-init: "cc_chef fails when using omnibus installer because UrlResponse doesn't have an 'encode' m

Re: [Cloud-init-dev] [Merge] ~jmelvin/cloud-init:my-topic-branch into cloud-init:master

2017-03-10 Thread Scott Moser
hi, i think what you want is this; http://paste.ubuntu.com/24152971/ that will basically dump the bytes string from the url into the file. where as what you have there will go through utf decode in the str(content) path. the end result is that if there was something that was not utf-8 you'd rai

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/feature-flags into cloud-init:master

2017-03-10 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:5cd84634774ba812b0683794b6b7ab59279dcbfb https://jenkins.ubuntu.com/server/job/cloud-init-ci/99/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/99 SUCCESS: https

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/feature-flags into cloud-init:master

2017-03-10 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:49f56d4d0116230bcb026cac1ff0302b55a483d1 https://jenkins.ubuntu.com/server/job/cloud-init-ci/98/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/98 SUCCESS: https

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/feature-flags into cloud-init:master

2017-03-10 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/feature-flags into cloud-init:master has been updated. Commit Message changed to: Add feature flags to cloudinit.version. This exposes a mechanism for users of cloud-init to determine if a version has a specific feature, and adds documentation to

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/feature-flags into cloud-init:master

2017-03-10 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:feature/feature-flags into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/319605 -- Your team cloud init developm