Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:integration-testing-tmpdir into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:735e7bc095d9f1a4ca373b70288d89bdfd713b92 https://jenkins.ubuntu.com/server/job/cloud-init-ci/193/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/193 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:4990a439de95e2641c912d08b969b2c8dc848245 https://jenkins.ubuntu.com/server/job/cloud-init-ci/192/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/192 SUCCESS: htt

[Cloud-init-dev] [Merge] ~tagatac/cloud-init:docs into cloud-init:master

The proposal to merge ~tagatac/cloud-init:docs into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~tagatac/cloud-init/+git/cloud-init/+merge/321481 -- Your team cloud init development team is requested to review the proposed

[Cloud-init-dev] [Merge] ~tagatac/cloud-init:docs into cloud-init:master

The proposal to merge ~tagatac/cloud-init:docs into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tagatac/cloud-init/+git/cloud-init/+merge/321481 -- Your team cloud init development team is requested to review the pr

[Cloud-init-dev] [Merge] ~tagatac/cloud-init:docs into cloud-init:master

The proposal to merge ~tagatac/cloud-init:docs into cloud-init:master has been updated. Commit Message changed to: doc: correct grammar in capabilities.rst For more details, see: https://code.launchpad.net/~tagatac/cloud-init/+git/cloud-init/+merge/321481 -- Your team cloud init development te

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

Diff comments: > diff --git a/doc/rtd/topics/network-config-format-eni.rst > b/doc/rtd/topics/network-config-format-eni.rst > new file mode 100644 > index 000..e4bcbe7 > --- /dev/null > +++ b/doc/rtd/topics/network-config-format-eni.rst > @@ -0,0 +1,14 @@ > +.. _network_config_eni: > + > +N

[Cloud-init-dev] [Merge] ~tagatac/cloud-init:docs into cloud-init:master

The proposal to merge ~tagatac/cloud-init:docs into cloud-init:master has been updated. Commit Message changed to: minor: correct grammar in capabilities.rst For more details, see: https://code.launchpad.net/~tagatac/cloud-init/+git/cloud-init/+merge/321481 -- Your team cloud init development

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1677710-ds-identify-fix-maas-detect into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:a68e7d50d25e774018588a5312c7698c38ec4de4 https://jenkins.ubuntu.com/server/job/cloud-init-ci/189/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/189 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1677710-ds-identify-fix-maas-detect into cloud-init:master

here is my little attempt at getting some speed info on this $ cat foo.sh #!/bin/sh if [ $# -eq 0 ] || [ "$1" = "-h" -o "$1" = "--help" ]; then cat

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1677710-ds-identify-fix-maas-detect into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1677710-ds-identify-fix-maas-detect into cloud-init:master. Commit message: ds-identify: fix detecting of maas datasource. The reading of MAAS datasource configuration was simply broken. it was looking in /etc/cloud/*maas*.cfg rather than

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1677710-ds-identify-fix-maas-detect into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1677710-ds-identify-fix-maas-detect into cloud-init:master has been updated. Commit Message changed to: ds-identify: fix detecting of maas datasource. The reading of MAAS datasource configuration was simply broken. it was looking in /etc/cloud/*maas

Re: [Cloud-init-dev] [Merge] ~tagatac/cloud-init:docs into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:b827cc78d93b1562013571da52c0a21bcd435a37 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):

[Cloud-init-dev] [Merge] ~tagatac/cloud-init:docs into cloud-init:master

David Tagatac has proposed merging ~tagatac/cloud-init:docs into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~tagatac/cloud-init/+git/cloud-init/+merge/321481 -- Your team cloud init development team is r

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1675576-netplan-delete-builtin into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:9022eadfd10be317d600ef50e58ca6ee52136894 https://jenkins.ubuntu.com/server/job/cloud-init-ci/186/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/186 SUCCESS: htt

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1675576-netplan-delete-builtin into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1675576-netplan-delete-builtin into cloud-init:master. Commit message: net: in netplan renderer delete known image-builtin content. When rendering network configuration to netplan, remove known "builtin" configurations. The specific exampl

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1675576-netplan-delete-builtin into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1675576-netplan-delete-builtin into cloud-init:master has been updated. Commit Message changed to: net: in netplan renderer delete known image-builtin content. When rendering network configuration to netplan, remove known "builtin" configurations. T

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/ds-identify-none-twice into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/ds-identify-none-twice into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321208 -- Your team cloud init development team is requeste

[Cloud-init-dev] [Merge] ~raharper/cloud-init:net-v2-dont-print-udevadm-commands into cloud-init:master

The proposal to merge ~raharper/cloud-init:net-v2-dont-print-udevadm-commands into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321222 -- Your team cloud init development team

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:1f14397c2ed5da58a0df644b1324739b5315f014 https://jenkins.ubuntu.com/server/job/cloud-init-ci/185/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/185/console

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master

https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321222 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321465 Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master has been updated. Commit Message changed to: net: replace print statements with debug in netplan renderer. Just replace a few print statements that leaked into the netplan render code. Also r

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321465 -- Your team c

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

Thanks for the input; I'll update. Diff comments: > diff --git a/doc/rtd/topics/network-config-format-eni.rst > b/doc/rtd/topics/network-config-format-eni.rst > new file mode 100644 > index 000..e4bcbe7 > --- /dev/null > +++ b/doc/rtd/topics/network-config-format-eni.rst > @@ -0,0 +1,14 @@ >

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

Ryan, this looks really good. you did a lot of sleuthing! there are some comments inline, i read mostly around the 'cloud-init' parts, i very lightly skimmed the v1 and v2 doc sections. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321397 Your team cloud init develo

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

Ryan, this looks really good. you did a lot of sleuthing! there are some comments inline, i read mostly around the 'cloud-init' parts, i very lightly skimmed the v1 and v2 doc sections. Diff comments: > diff --git a/doc/rtd/topics/network-config-format-eni.rst > b/doc/rtd/topics/network-conf