Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/digital-ocean-more-strict into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:09b7035d3f448b1f8b7fab29d3884c903bce8d97 https://jenkins.ubuntu.com/server/job/cloud-init-ci/202/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/202 SUCCESS:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/digital-ocean-more-strict into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/digital-ocean-more-strict into cloud-init:master. Commit message: DigitalOcean: be more strict in network configuration conversion. a.) warn on a 'nic' type in metadata that is unknown. b.) raise exception if metadata defines a nic

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/digital-ocean-more-strict into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/digital-ocean-more-strict into cloud-init:master has been updated. Commit Message changed to: DigitalOcean: be more strict in network configuration conversion. a.) warn on a 'nic' type in metadata that is unknown. b.) raise exception if metadata

Re: [Cloud-init-dev] [Merge] ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:08b55ba70dec36aeeafd78cb383641a9f9c269e0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/200/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/200 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master

Cool feedback, and should be considered across the rest of the current testcases (as I've lazily cut & pasted from current).I'll address here of course. :) Thanks! On Fri, Mar 31, 2017 at 1:46 PM, Ryan Harper wrote: > Looks good! Some feedback in the integration

Re: [Cloud-init-dev] [Merge] ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master

Looks good! Some feedback in the integration test. Diff comments: > diff --git a/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml > b/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml > index 3cd28df..9b75d49 100644 > ---

Re: [Cloud-init-dev] [Merge] ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:445a52033755a17a54eb2685fd6a46a40b94a60b https://jenkins.ubuntu.com/server/job/cloud-init-ci/199/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/199 SUCCESS:

[Cloud-init-dev] [Merge] ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master

Jon Grimm has proposed merging ~jgrimm/cloud-init:fix_chef_example_source into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1678145 in cloud-init: "example chef config broken: upstream apt source has changed"

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c2e308ad4eca888acee9aeac704f6e3784708b4c https://jenkins.ubuntu.com/server/job/cloud-init-ci/196/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/196

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:895e007a51d093c2d2ccb6233d9cd153256e57d9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/195/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/195/console

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

Generally speaking, get_interfaces_by_mac was simply broken for any occurance of duplicate mac addresses. From that perspective, this is simply a fix. The reality was that the "last" nic (per os.listdir()) would be the one chosen, which is not even sorted() (unless /sys was returning a directory

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:78e4aae8ae72b9173e1aa578a7bcd5d3ac581cb9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/194/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/194 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > old mode 100755 > new mode 100644 > index 1cf98ef..ff358c6 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -358,6 +386,8 @@ def get_interfaces_by_mac(devs=None): >

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1669860-no-rename-bonds into cloud-init:master has been updated. Commit Message changed to: Fix bug that resulted in an attempt to rename bonds or vlans. When cloud-init ran in the init stage (after networking had come up). A bug could occur where