Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cyaml-loading into cloud-init:master

2017-05-04 Thread Chad Smith
1) We won't have libyaml-dev as a dependency just the shared lib of libyaml-0-2. I've added it as a Recommends and put in logic to handle ImportErrors on CSafeLoader which fall back to SafeLoader 2) I've got a branch up in github which installs tox-needed system debs that we can review as part

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cyaml-loading into cloud-init:master

2017-05-04 Thread Chad Smith
>From Ryan: Some thoughts on this: 1) we don't want users who apt install cloud-init to also pull down python-devel, gcc and have to compile the extension, so please don't change package deps here 2) this is currently an issue for the tox/venv environment, so let's focus on how to enable the

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:make-deb-cleanup into cloud-init:master

2017-05-04 Thread Chad Smith
Thanks Ryan for the review points, I know you are commenting on the Safeloader proposal which is over here https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323088 so I'll copy them over to that proposal and comment over there. --

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:make-deb-cleanup into cloud-init:master

2017-05-04 Thread Ryan Harper
Some thoughts on this: 1) we don't want users who apt install cloud-init to also pull down python-devel, gcc and have to compile the extension, so please don't change package deps here 2) this is currently an issue for the tox/venv environment, so let's focus on how to enable the SafeLoader