Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:a4cf423f7e8481206e1442d2d441e8317bf7df73
https://jenkins.ubuntu.com/server/job/cloud-init-ci/410/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/410/console
Review: Approve continuous-integration
PASSED: Continuous integration, rev:de1a75cd63b2fedf416c96ee2da5b97434a2
https://jenkins.ubuntu.com/server/job/cloud-init-ci/409/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/409
SUCCESS:
htt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1788d55154cc7254a4589fdd08ff2e7770821b9c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/408/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/408
SUCCESS:
htt
Review comments addressed Scott. Thank you! I tweaked the rst doc layout a bit
to make sure we could use structured text within the Config keys doc section.
Let's talk about the runtime dependency concern tomorrow to see what we can do.
Not having the dependency defined means we'd have to remov
Review: Approve continuous-integration
PASSED: Continuous integration, rev:d625066059e2f5e7189edb29bd7f669268def314
https://jenkins.ubuntu.com/server/job/cloud-init-ci/407/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/407
SUCCESS:
htt
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:9aff5a184f78fed5c63e514681a402186b871a90
https://jenkins.ubuntu.com/server/job/cloud-init-ci/406/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/406/console
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:e6aabcd0274ad4ac4f3564d89a3f0736beea96bc
https://jenkins.ubuntu.com/server/job/cloud-init-ci/405/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/405/console
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -737,6 +737,21 @@ def exec_mkpart(table_type, device, layout):
> re
> It doesn't look like you dropped blockdev as you say in your comment.
The drop was a drop from the previous commit
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324639
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/16
This has no merge proposal shown because of bug 1693543
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
It doesn't look like you dropped blockdev as you say in your comment.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -73
Review: Approve continuous-integration
PASSED: Continuous integration, rev:6b0c90d33703ac075c42bb4a52d710f636d5a030
https://jenkins.ubuntu.com/server/job/cloud-init-ci/404/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/404
SUCCESS:
htt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:3f615ab91bf5c569354bc0a896901843f722c91f
https://jenkins.ubuntu.com/server/job/cloud-init-ci/403/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/403
SUCCESS:
htt
The proposal to merge
~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/gce-ssh-key-attributes
into cloud-init:master has been updated.
Commit Message changed to:
Update the attribute used to find SSH keys in GCE
Per the documentation at
https://cloud.google.com/compute/docs/storing-retriev
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/gce-ssh-key-attributes
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1693582 in cloud-init: "cloud-init uses a deprecated metadata path for
GCE instanc
I think i'm going to drop the blockdev --rereadpt
It should not strictly be needed during boot.
a udevadm settle shoudl be sufficient.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324639
Your team cloud-init commiters is requested to review the proposed merge of
~smose
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:9ee8f78041acf880503a10258ab48c0743b61b19
https://jenkins.ubuntu.com/server/job/cloud-init-ci/402/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/402/console
I like it very much.
Some comments inline. comments.
looking at diff i see that tools/cloudconfig-schema has some
whitespace-end-of-line issues.
tools/cloudconfig-schema needs chmod +x.
tools/cloudconfig-schema: def error() should got to sys.stderr.write(message +
"\n") ?
might as well write e
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:7fd77646851386a148e1d26d655fbe8163f72a14
https://jenkins.ubuntu.com/server/job/cloud-init-ci/401/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/401/console
Review: Approve continuous-integration
PASSED: Continuous integration, rev:7e0ab34d1183bdcc43325acd8ec05fe49250c891
https://jenkins.ubuntu.com/server/job/cloud-init-ci/400/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/400
SUCCESS:
htt
Review: Approve
LGTM
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..adde1df 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -737,6 +737,32 @@ def exec_mkpart(table_type, devic
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:a9a45835731979900e59ff488b8ac9a2b2f3e830
https://jenkins.ubuntu.com/server/job/cloud-init-ci/399/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/399/console
The proposal to merge ~chad.smith/cloud-init:cc-ntp-schema-validation into
cloud-init:master has been updated.
Description changed to:
cc_ntp: Add schema definition and passive schema validation.
cloud-config files are very flexible and permissive. This branch adds a
supported schema definitio
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:7fd77646851386a148e1d26d655fbe8163f72a14
https://jenkins.ubuntu.com/server/job/cloud-init-ci/398/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/398/console
Chad Smith has proposed merging ~chad.smith/cloud-init:cc-ntp-schema-validation
into cloud-init:master.
Commit message:
cc_ntp: Add schema definition and passive schema validation.
cloud-config files are very flexible and permissive. This branch adds a
supported schema definition to cc_ntp so t
Scott Moser has proposed merging
~smoser/cloud-init:bug/1692093-sometimes-need-settle into cloud-init:master.
Commit message:
disk_setup: udev settle before attempting partitioning or fs creation.
This attempts to use udevadm settle to wait until devices have been
fully "realized". If a device
The proposal to merge ~chad.smith/cloud-init:cc-ntp-schema-validation into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Add schema definition and passive schema validation.
cloud-config files are very flexible and permissive. This branch adds a
supported schema defini
The proposal to merge ~smoser/cloud-init:bug/1692093-sometimes-need-settle into
cloud-init:master has been updated.
Commit Message changed to:
disk_setup: udev settle before attempting partitioning or fs creation.
This attempts to use udevadm settle to wait until devices have been
fully "realiz
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:86e241cbcca30f6bc998fa9652665ed1a638e56c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/397/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/397/console
This supersedes
https://code.launchpad.net/~jingni.wjj/cloud-init/+git/cloud-init/+merge/323306.
It has some re-wording of Junjie's commit, and then a commit to show my
additional changes.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
Your team cloud-init commite
Scott Moser has proposed merging ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master.
Commit message:
AliYun: Enable platform identification and enable by default.
AliYun cloud platform is now identifying themselves by setting the dmi
product id to the well known value "Alibaba Cloud
The proposal to merge ~smoser/cloud-init:bug/fix-py26-tests-assertNone into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324585
--
Your team cloud-init commiters is requested to
The proposal to merge ~smoser/cloud-init:bug/fix-py26-tests-assertNone into
cloud-init:master has been updated.
Commit Message changed to:
tests: fix unit tests usage of assertNone on centos 6.
python2.6 unittest.TestCase does not have the assertIsNone or
assertIsNotNone. We just have to expli
33 matches
Mail list logo
