Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
___
Mailing li
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
--
Your team cloud-init commiters is requested to review the
Review: Approve continuous-integration
PASSED: Continuous integration, rev:092ea4027f241e6272588ae622b1ebd2692dde08
https://jenkins.ubuntu.com/server/job/cloud-init-ci/430/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/430
SUCCESS:
htt
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:4999cd8ef760973e37a92b2755b7454849fbcb00
https://jenkins.ubuntu.com/server/job/cloud-init-ci/429/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/429/console
I have to think some more on the 'FIXME' bits here.
But i'd like feedback on teh added unit tests.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324274
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/1683038-ec2-no-warn
The proposal to merge ~smoser/cloud-init:bug/1683038-ec2-no-warn-on-explicit
into cloud-init:master has been updated.
Commit Message changed to:
Ec2: do not warn user of strict if Ec2 is explicitly set.
If the system is configured with datasource_list of either just
'Ec2' or 'Ec2' and 'None', t
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
--
Your team cloud-init commiters is requested to revie
Review: Approve continuous-integration
PASSED: Continuous integration, rev:8db9cd3f44c3848574a7e690a53bb3d8962fb9f6
https://jenkins.ubuntu.com/server/job/cloud-init-ci/428/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/428
SUCCESS:
htt
Review: Approve
+1 thanks for the discussion.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
_
Review: Approve continuous-integration
PASSED: Continuous integration, rev:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/427/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/427
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:3ae4ef707d48a9ba39a26a8d3dee2832ff671844
https://jenkins.ubuntu.com/server/job/cloud-init-ci/426/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/426/console
Thanks for the clarification and background on the datasource list ordering.
And I see your point on git log (as that's how I determined what the intent of
the var was in the first place).
+1 on the separate mocked unit test for _is_aliyun() to exercise the interface
we are actually calling.
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1f7e87c2996d6a3af23e0226cc5d64b0a9106584
https://jenkins.ubuntu.com/server/job/cloud-init-ci/425/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/425
SUCCESS:
htt
OK, So i thought some more, and with regard to the order of the two
'datasource_lists'.
Some points to think about
a.) If EC2's 'strict_id' is set to "warn" or "false", then the Ec2 datasource
will poll and time out very annoyingly. "true" is the default setting in
trunk, but not yet in xenial.
Scott Moser has proposed merging ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master.
Commit message:
AliYun: Enable platform identification and enable by default.
AliYun cloud platform is now identifying themselves by setting the dmi
product id to the well known value "Alibaba Cloud
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
--
Your team cloud-init commiters is requested to rev
> Thanks for this good work approved pending your decision on the following
> comments.
>
> My comments will be made per the consolidated visual diff @
> http://paste.ubuntu.com/24716726/
>
> line 49 in the above diff:
> Since order of datasources matters to determine which datasource is detectr
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:0c5f1e428c05f9eacb19e88fb9473ba8bf13992d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/424/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/424/console
Review: Approve
Thanks for this good work approved pending your decision on the following
comments.
My comments will be made per the consolidated visual diff @
http://paste.ubuntu.com/24716726/
line 49 in the above diff:
Since order of datasources matters to determine which datasource is de
19 matches
Mail list logo
