The proposal to merge
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
--
Your team cloud-init
@smoser: thanks for the template!
@rharper: responses below two big points:
1) Knowning when network is up is a better solution than the sleep. May try to
see if cloud-init is finished if cloud-init is in the images or some other
solution.
2) Knowing when we need to use the proxy. When this is
The proposal to merge
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
--
Your team cloud-init
Chad Smith has proposed merging
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
Tests:
i use 'newscript' to create scripts once they start needing options.
make sure you use it with '--spaces'
http://smoser.brickies.net/git/?p=tildabin.git;a=blob;f=newscript;h=494d31a8f8fa0c83d7c8b03d3d63deb641709b99;hb=HEAD
Diff comments:
> diff --git a/tools/test-centos-run.sh
Review: Approve continuous-integration
PASSED: Continuous integration, rev:686a919686578ccfb3a05c568dbf0ca88efc3699
https://jenkins.ubuntu.com/server/job/cloud-init-ci/449/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/449
SUCCESS:
fixed all that round of comments.
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 9e9c05a..1d92db0 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,53 +670,213 @@ class
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 9e9c05a..1d92db0 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,53 +670,213 @@ class NetworkStateInterpreter(object):
> return subnets
>
8 matches
Mail list logo