Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master

2017-07-31 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:491585acd21b21dc18defc90cc1e00489ea00769 https://jenkins.ubuntu.com/server/job/cloud-init-ci/106/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ub

[Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master

2017-07-31 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1701420 in cloud-init: "Created by cloud-init comment being added on every reboot to /etc

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master

2017-07-31 Thread Rich Lees
Review: Approve visual, basic testing Looks good. Also did some basic tests and it fixes all the problems I had found with CloudInit 0.7.9 on ArchLinux. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328114 Your team cloud-init commiters is requested to review the propos

[Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

2017-07-31 Thread Scott Moser
The proposal to merge ~powersj/cloud-init:fix-arch-dns into cloud-init:master has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914 -- Your team cloud-init commiters is requested to review the p

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

2017-07-31 Thread Scott Moser
I'm marking this rejected as I had opened up https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328114 with some related work and unit tests with it. I really hate how harsh 'rejected' sounds. -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914 You