The proposal to merge ~aromito/cloud-init:cloud-init-BZ_1673170 into
cloud-init:master has been updated.
Description changed to:
Applying the following patch the script make a double check on the keys present
into the array before the if statement.
diff --git a/cloudinit/cmd/main.py b/cloudini
Antonio Romito has proposed merging ~aromito/cloud-init:cloud-init-BZ_1673170
into cloud-init:master.
Commit message:
I had a look to the /usr/lib/python2.7/site-packages/cloudinit/cmd/main.py
script and I found that it fail in the following part of code:
~~~
...
if mode == "modules-final":
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index a8a232b..446b7b9 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1596,14 +1596,22 @@ def json_dumps(data):
>separators=(',', ': '), default=json_serialize_default)
>
>
> -def
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index a8a232b..446b7b9 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1596,14 +1596,22 @@ def json_dumps(data):
>separators=(',', ': '), default=json_serialize_default)
>
>
> -def
Review: Approve continuous-integration
PASSED: Continuous integration, rev:8bff68c6fb035f09ed343bdd9e0f3d9fbf5d1755
https://jenkins.ubuntu.com/server/job/cloud-init-ci/558/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Antonio Romito has proposed merging ~aromito/cloud-init:cloud-init-BZ_1673170
into cloud-init:master.
Commit message:
cloud-final.service (cloud-init modules --mode final) fail for "KeyError:
'modules-init'" after upgrade to version 18.2-1 in RHEL7.6
Requested reviews:
cloud-init commiters
Ryan Harper has proposed merging
~raharper/cloud-init:fix/netplan-nameserver-alias into cloud-init:master.
Commit message:
netplan: Don't render yaml aliases when dumping netplan
Cloud-init rendered netplan with duplicate aliases if a network config
included "global" nameserver/search values
The proposal to merge ~d-info-e/cloud-init:add-idea-gitignore into
cloud-init:master has been updated.
Commit message changed to:
add PyCharm IDE .idea/ path to .gitignore
For more details, see:
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/362863
--
Your team cloud-in
PyCharm IDE will use .idea/ folder to save some project specific information.
We do not want to have those being committed.
--
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/362863
Your team cloud-init commiters is requested to review the proposed merge of
~d-info-e/cloud
do3meli has proposed merging ~d-info-e/cloud-init:add-idea-gitignore into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/362863
--
Your team cloud-init commiters is reque
10 matches
Mail list logo
