Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

2019-05-03 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py > index 4d19f56..91046b5 100644 > --- a/cloudinit/net/network_state.py > +++ b/cloudinit/net/network_state.py > @@ -707,6 +707,13 @@ class NetworkStateInterpreter(object): > item_params =

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

2019-05-03 Thread Dan Watkins
Do we need to handle older versions of netplan that _don't_ understand the new key? -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/366935 Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spe

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

2019-05-03 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:67222ba81ed350da08cec2c3390d66040504da3a https://jenkins.ubuntu.com/server/job/cloud-init-ci/703/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

2019-05-03 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master. Commit message: netplan: update netplan key mappings for gratuitous-arp Previous versions of netplan included a misspelling for the bond parameter around gratuitous-arp. Th