Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:useradd into cloud-init:master

On Mon, Aug 12, 2019 at 02:31:18PM -, Ryan Harper wrote: > The method is call add_user and the variables match the method. If the variable matched the method, I'd expect it to be add_user_cmd. I'd be fine with that, if that's what you would prefer? > So now we have > > def add_user() >

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:useradd into cloud-init:master

The method is call add_user and the variables match the method. So now we have def add_user() useradd_cmd = Isn't this the same confusion? The command to add a user could be something else. In cloudinit/distros/freebsd.py for example, the adduser_cmd , is 'pw useradd'. --

Re: [Cloud-init-dev] [Merge] ('~daniel-thewatkins/cloud-init/+git/cloud-init', ':', 'useradd') into ('cloud-init', ':', 'master')

Review: Approve continuous-integration PASSED: Continuous integration, rev:65f501f39cc3646a761028733a4bfeb370cd9cf5 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1036/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:useradd into cloud-init:master

Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:useradd into cloud-init:master. Commit message: distros: fix confusing variable names Building the subp arguments for a `useradd` call in a variable named `adduser_cmd` is extremely confusing; let's not do that.