doing an import in an exception handling path doesn't seem right.
other than that, good work.
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index aa23b3f..49433dc 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1599,10 +1599,36 @@ def
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:45e8ac7edc90bde12416380daf7284080204
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1184/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
The proposal to merge
~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into
cloud-init:master has been updated.
Commit message changed to:
util: json.dumps on python 2.7 will handle UnicodeDecodeError on binary
Since python 2.7 doesn't handle UnicodeDecodeErrors with the
Chad Smith has proposed merging
~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into
cloud-init:master.
Commit message:
util: json.dumps on python 2.7 will handle unicodedecodeerror on binary
Since python 2.7 doesn't handle UnicodeDecodeErrors with the default
handler
LP:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:39455743d881c39e9721968ae4de5dd1bcf350fc
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1183/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS:
Ryan Harper has proposed merging ~raharper/cloud-init:fix/ovf-reset-instance-id
into cloud-init:master.
Commit message:
ovf: do not generate random instance-id for IMC customization path
Cloud-init will not operate properly if the instance-id value changes
on each boot. This is the source of a
Ryan Harper has proposed merging
~raharper/cloud-init:fix/sysconfig-distro-variant into cloud-init:master.
Commit message:
sysconfig: use distro variant to check if available
The sysconfig renderer used the distro name directly which mean
some variants of distros were not considered
Review: Approve continuous-integration
PASSED: Continuous integration, rev:7adb51a4efb76b77731ae740797be2303a41caaa
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1179/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS:
Chad Smith has proposed merging ~chad.smith/cloud-init:cleanup/zstack-docs into
cloud-init:master.
Commit message:
docs: fix zstack documentation lints
Resolve the following lints raised by 'make doc':
- doc/rtd/topics/datasources/zstack.rst:5: D001 Line too long
-
9 matches
Mail list logo
