Diff comments:
> diff --git a/tests/unittests/test_distros/test_debian.py
> b/tests/unittests/test_distros/test_debian.py
> new file mode 100644
> index 000..bd7721c
> --- /dev/null
> +++ b/tests/unittests/test_distros/test_debian.py
> @@ -0,0 +1,70 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/tests/unittests/test_distros/test_debian.py
> b/tests/unittests/test_distros/test_debian.py
> new file mode 100644
> index 000..bd7721c
> --- /dev/null
> +++ b/tests/unittests/test_distros/test_debian.py
> @@ -0,0 +1,70 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..8745ee7 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -557,6 +558,67 @@ def get_interfaces():
> return ret
>
>
> +class EphemeralIPv4Network(object):
>
Per our discussion today, I simplified logic in EphemeralIPv4Network context
manager to first attempt to add a network address and handle a non-zero exit
code if the address already exits.
All changes have been made per review comments, I separated out get_ip_info
utility function so we can pro
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Commit Message changed to:
cloudinit.net: add initialize_network_device function and tests
This is not yet called, but will be called in a subsequent Ec2-related branch
to manua
Just tested on ubuntu AWS. minor fix needed to remove the route before removing
the address, because the side-effect of removing the addr is the route is
auto-deleted.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested t
Just validated on cent6 too:
2017-07-27 21:33:19,762 - handlers.py[DEBUG]: finish:
init-local/search-Ec2Local: SUCCESS: found local data from DataSourceEc2Local
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested to revie
Chad Smith has proposed merging ~chad.smith/cloud-init:aws-local-dhcp into
cloud-init:master with ~chad.smith/cloud-init:unittests-in-cloudinit-package as
a prerequisite.
Commit message:
ec2: Allow Ec2 to run in init-local using dhclient in a sandbox.
This branch is a prerequisite for IPv6
The proposal to merge ~chad.smith/cloud-init:aws-local-dhcp into
cloud-init:master has been updated.
Commit Message changed to:
ec2: Allow Ec2 to run in init-local using dhclient in a sandbox.
This branch is a prerequisite for IPv6 support in AWS and allows Ec2 datasource
to query the metadata
Diff comments:
> diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py
> new file mode 100644
> index 000..4d59bd0
> --- /dev/null
> +++ b/cloudinit/net/dhcp.py
> @@ -0,0 +1,118 @@
> +# Copyright (C) 2017 Canonical Ltd.
> +#
> +# Author: Chad Smith
> +#
&
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 4ec9592..ae0fe26 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -73,21 +77,25 @@ class DataSourceEc2(sources.DataSource):
>
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -233,15 +231,24 @@ def generate_fallback_config(blacklist_drivers=None,
> config_driver=None):
> if D
All comments addressed, and we now handle backward compatibility for old
metadata versions.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -175,12 +175,10
Chad Smith has proposed merging ~chad.smith/cloud-init:analyze into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/328819
tools: Add tooling for basic cloud-init
Approved with minor nits questions inline. +1!
Validated and inspected netplan output with the following:
PYTHONPATH=. ./tools/net-convert.py --network-data=net-config.yaml --kind=yaml
--output-kind=netplan --directory=out.d --mac=eth0,52:54:00:12:34:00
--mac=ens4,52:54:00:12:34:02
Prior to t
Thanks for the submit Ryan, is there an existing bug that was filed against
cloud-init for this issue? It'd be great to have the bug as reference for
future concerned parties/clouds.
--
https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877
Your team cloud-init commiters is
Chad Smith has proposed merging
~chad.smith/cloud-init:cc-landscape-py3-config-fix into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1699282 in cloud-init: "cloud-init process fails to configure puppet"
https://bugs.launchpad.net/
The proposal to merge ~chad.smith/cloud-init:cc-landscape-py3-config-fix into
cloud-init:master has been updated.
Description changed to:
cc_landscape & cc_puppet: Fix six.StringIO use in writing configs
Both landscape and puppet modules had issues with the way they wrote
/etc/landscape/client
comments addressed
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_landscape.py
> b/tests/unittests/test_handler/test_handler_landscape.py
> new file mode 100644
> index 000..d35ba60
> --- /dev/null
> +++ b/tests/unittests/test_handler/test_handler_landscape.py
> @@ -
Chad Smith has proposed merging ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master with ~chad.smith/cloud-init:analyze as a prerequisite.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud
Looks good, just some inline nits and questions
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index abfb81f..b2904e8 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -246,9 +250,17 @@ def apply_locale(locale, sys_path=
Looks good, initial comments and running through tests now.
Diff comments:
> diff --git a/tests/cloud_tests/images/kvm.py b/tests/cloud_tests/images/kvm.py
> new file mode 100644
> index 000..008acef
> --- /dev/null
> +++ b/tests/cloud_tests/images/kvm.py
> @@ -0,0 +1,75 @@
> +# This file is
Additionally, since you are importing paramiko, we probably need a dev
dependency added to requirements-test.txt
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:cii-kv
Diff comments:
> diff --git a/tests/cloud_tests/instances/kvm.py
> b/tests/cloud_tests/instances/kvm.py
> new file mode 100644
> index 000..c855e07
> --- /dev/null
> +++ b/tests/cloud_tests/instances/kvm.py
> @@ -0,0 +1,222 @@
> +# This file is part of cloud-init. See LICENSE file for licen
The proposal to merge ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master has been updated.
Description changed to:
schema cli: Add schema subcommand to cloud-init cli and cc_runcmd schema
This branch adds an jsonschema definition for the cc_runcmd module. cc_ntp is
the only other
The proposal to merge ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master has been updated.
Description changed to:
schema cli: Add schema subcommand to cloud-init cli and cc_runcmd schema
This branch adds an jsonschema definition for the cc_runcmd module. cc_ntp is
the only other
The proposal to merge ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master has been updated.
Description changed to:
schema cli: Add schema subcommand to cloud-init cli and cc_runcmd schema
This branch adds an jsonschema definition for the cc_runcmd module. cc_ntp is
the only other
Diff comments:
> diff --git a/cloudinit/config/cc_puppet.py b/cloudinit/config/cc_puppet.py
> index dc11561..28b1d56 100644
> --- a/cloudinit/config/cc_puppet.py
> +++ b/cloudinit/config/cc_puppet.py
> @@ -43,12 +45,13 @@ yaml notation).
> install:
> version:
> conf:
Thanks for the patience on this. I figured out the issue I had with my calls to
helpers.wrap_and_call resulted from relying on mock.patch(return_value) instead
of mock.patch(new)
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_landscape.py
> b/tests/unittests/test_hand
Chad Smith has proposed merging
~chad.smith/cloud-init:fix-cloudinit-subcommands into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1712676 in cloud-init: "Cloud-init analyzeand devel commandline
traceback"
https://bugs.launchpad
Chad Smith has proposed merging ~chad.smith/cloud-init:aws-ipv6-dhcp-support
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329499
ec2: Add IPv6 dhcp support to
The proposal to merge ~chad.smith/cloud-init:aws-ipv6-dhcp-support into
cloud-init:master has been updated.
Description changed to:
ec2: Add IPv6 dhcp support to Ec2DataSource.
DataSourceEc2 now parses the metadata for each nic to determine if
configured for ipv6 and/or ipv4 addresses. In AWS f
The proposal to merge ~chad.smith/cloud-init:aws-ipv6-dhcp-support into
cloud-init:master has been updated.
Description changed to:
ec2: Add IPv6 dhcp support to Ec2DataSource.
DataSourceEc2 now parses the metadata for each nic to determine if
configured for ipv6 and/or ipv4 addresses. In AWS f
Chad Smith has proposed merging ~chad.smith/cloud-init:json-datasource-metadata
into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud
The proposal to merge ~chad.smith/cloud-init:aws-ipv6-dhcp-support into
cloud-init:master has been updated.
Description changed to:
ec2: Add IPv6 dhcp support to Ec2DataSource.
DataSourceEc2 now parses the metadata for each nic to determine if
configured for ipv6 and/or ipv4 addresses. In AWS f
The proposal to merge ~chad.smith/cloud-init:json-datasource-metadata into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329589
--
Your team cloud-init commiters is
Oops. Thanks Andrew. Yeah, sloppy. my bad. Hmm wondering if we need IOError
there too.
--
https://code.launchpad.net/~ajorgens/cloud-init/+git/cloud-init/+merge/329653
Your team cloud-init commiters is requested to review the proposed merge of
~ajorgens/cloud-init:py27-analyze into cloud-init:m
The proposal to merge ~chad.smith/cloud-init:unittest-oauthlib-import into
cloud-init:master has been updated.
Description changed to:
url_helper: dynamically import oauthlib import from inside oauth_headers
oauth_headers is the only function which requires oauthlib, move the
import and ImportE
Chad Smith has proposed merging ~chad.smith/cloud-init:unittest-oauthlib-import
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329872
url_helper: dynamically
We need to drop the module from doc/rtd/topics/modules.rst too.
.. automodule:: cloudinit.config.cc_ubuntu_init_switch
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329946
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:c
so that I understand intent here. We are leaving upstart logic in place so that
tip could be used to still generate upstart-based packages if we wanted. We
just don't want to package that init system by default anymore right?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merg
Hrm, I'm still seeing upstart jobs included in /etc/init/*conf
dpkg -L cloud-init | grep etc/init
/etc/init
/etc/init/cloud-init-blocknet.conf
/etc/init/cloud-init-container.conf
/etc/init/cloud-init-nonet.conf
/etc/init/cloud-final.conf
/etc/init/cloud-init-local.conf
/etc/init/cloud-log-shutdow
Chad Smith has proposed merging
~chad.smith/cloud-init:bug/ec2-tests-unmocked-metadata into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330040
ec2 tests: Stop
The proposal to merge ~chad.smith/cloud-init:bug/ec2-tests-unmocked-metadata
into cloud-init:master has been updated.
Description changed to:
ec2 tests: Stop leaking calls through unmocked metadata addresses
DataSourceEc2 behavior changed to first check a minimum acceptable
metadata version uri
The proposal to merge ~chad.smith/cloud-init:bug/ec2-tests-unmocked-metadata
into cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330040
--
Your team cloud-init commiters is re
The proposal to merge ~chad.smith/cloud-init:bug/ec2-tests-unmocked-metadata
into cloud-init:master has been updated.
Commit Message changed to:
ec2 tests: Stop leaking calls through unmocked metadata addresses
DataSourceEc2 behavior changed to first check a minimum acceptable
metadata version
The proposal to merge ~chad.smith/cloud-init:feature/move-base-testcase into
cloud-init:master has been updated.
Commit Message changed to:
tests: Move tests/unittests/helpers.py to cloudinit/tests/helpers
Long term, we want unit tests to be as close as possible to the module
they are testing t
The proposal to merge ~chad.smith/cloud-init:feature/move-base-testcase into
cloud-init:master has been updated.
Description changed to:
tests: Move tests/unittests/helpers.py to cloudinit/tests/helpers
Long term, we want unit tests to be as close as possible to the module
they are testing to i
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/move-base-testcase into cloud-init:master.
Commit message:
tests: Move tests/unittests/helpers.py to cloudinit/tests/helpers
Long term, we want unit tests to be as close as possible to the module
they are testing to improve test
The proposal to merge ~chad.smith/cloud-init:json-datasource-metadata into
cloud-init:master has been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329589
--
Your team cloud-init commiters is req
I'm pulling this together in another branch
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329589
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:json-datasource-metadata into cloud-init:master.
Chad Smith has proposed merging
~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330112
Datasources: Create
The proposal to merge ~chad.smith/cloud-init:unify-datasource-get-data into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330112
--
Your team cloud-init commiters is requ
Chad Smith has proposed merging
~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master with
~chad.smith/cloud-init:feature/move-base-testcase as a prerequisite.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Server Team CI bot (server-team-bot): continuous
> I've updated the original merge proposal so that applies cleanly and passes
> with current master. Please use that one, and let me fix it if it needs
> additional changes. Thanks!
Thanks Lars, forgot about those meddling vacations ;) welcome back
--
https://code.launchpad.net/~chad.smith/cloud-
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/schema-resizefs-bootcmd into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330243
schema: Add json
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema: Add json schema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Those
schema defintions are us
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema: Add json schema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Those
schema defintions are us
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema: Add json schema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Those
schema defintions are us
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema: Add json schema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Extend
schema.py to parse and
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema: Add json schema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Extend
schema.py to parse and
The proposal to merge
~chad.smith/cloud-init:tests/slow-openstack-datasource-tests into
cloud-init:master has been updated.
Description changed to:
tests: mock missed openstack metadata uri network_data.json
This missed mock in test_openstack resulted in a costly unit test timeout.
LP: #17143
Chad Smith has proposed merging
~chad.smith/cloud-init:tests/slow-openstack-datasource-tests into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1714376 in cloud-init: "unittests: OpenStack DS escape or timeout"
https://bugs.lau
Leaving the overhaul of register_mock_metaserver for a separate branch which
would consolidate AliYun, Ec2 and OpenStack tests to use the same httpretty
mocking pattern.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330253
Your team cloud-init commiters is requested
Ok so this adds a slight cost to non-x86 platforms init-network stage by
placing a maybe on OpenStack datasource right? This maybe openstack still won't
affect datasources which now run in init-local because they would have already
been discovered. So ConfigDrive, Ec2,SmartOS, OpenNebula,DO etc
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> index 1a81a89..c389029 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -261,6 +268,29 @@ class TestDsIdentify(CiTestCase):
> s
The proposal to merge
~chad.smith/cloud-init:tests/slow-openstack-datasource-tests into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330253
--
Your team cloud-init commiter
Thanks for working this josh. Here are a few more more comments. I'm still
seeing spurious issues on my laptop trying to run this (I just hit an OOM as
well) and NoValidConnectionsError from paramiko. But I have also seen
successful runs. I'm +1 on this iteration with various fixes/comments inli
Chad Smith has proposed merging
~chad.smith/cloud-init:config-modules-allow-distros-all into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith
The proposal to merge ~chad.smith/cloud-init:config-modules-allow-distros-all
into cloud-init:master has been updated.
Commit Message changed to:
cloud-config modules: honor distros definitions in each module
Modules can optionally define a list of supported distros on which they can run
by de
The proposal to merge ~chad.smith/cloud-init:config-modules-allow-distros-all
into cloud-init:master has been updated.
Commit Message changed to:
cloud-config modules: honor distros definitions in each module
Modules can optionally define a list of supported distros on which they can run
by de
The proposal to merge ~chad.smith/cloud-init:unify-datasource-get-data into
cloud-init:master has been updated.
Description changed to:
Datasources: Create DataSource.get_data method in parent and write json
metadata
Each DataSource subclass must define its own get_data method. This branch
form
Thanks for the review Ryan, pushed changes per your review comments. We should
be able to handle TypeError issues during json errors and attempt encoding or
exclusion of those items instead of bailing on everything.
Diff comments:
> diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources
Good suggestions Scott, I pulled in your changes and adapted cc_runcmd, cc_ntp,
cc_resizefs and cc_bootcmd to all set __doc__ through get_schema_doc().
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330243
Your team cloud-init commiters is requested to review the pro
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema and docs: Add jsonschema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Extend
schema.py to p
The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd
into cloud-init:master has been updated.
Description changed to:
schema and docs: Add jsonschema to resizefs and bootcmd modules
Add schema definitions to both cc_resizefs and cc_bootcmd modules. Extend
schema.py to pa
The proposal to merge ~chad.smith/cloud-init:unify-datasource-get-data into
cloud-init:master has been updated.
Description changed to:
Datasources: Create DataSource.get_data method in parent and write json
metadata
Each DataSource subclass must define its own get_data method. This branch
form
The proposal to merge ~chad.smith/cloud-init:unify-datasource-get-data into
cloud-init:master has been updated.
Description changed to:
Datasources: Create DataSource.get_data method in parent and write json
metadata
Each DataSource subclass must define its own get_data method. This branch
form
Chad Smith has proposed merging ~chad.smith/cloud-init:collect-logs into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626
cmdline: cloud-init collect-logs
Add a
The proposal to merge ~chad.smith/cloud-init:collect-logs into
cloud-init:master has been updated.
Description changed to:
cmdline: cloud-init collect-logs
Add a new collect-logs parameter to the cloud-init CLI. This script will
collect all logs pertinent to a cloud-init run and store them in a
The proposal to merge ~chad.smith/cloud-init:collect-logs into
cloud-init:master has been updated.
Description changed to:
cmdline: cloud-init collect-logs
Add a new collect-logs parameter to the cloud-init CLI. This script will
collect all logs pertinent to a cloud-init run and store them in a
Pulled the original content from
https://code.launchpad.net/~papodaca/cloud-init/+git/cloud-init/+merge/328943
and addresses review comments as well as added unit tests.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330712
Your team cloud-init commiters is requested
Chad Smith has proposed merging ~chad.smith/cloud-init:chef_omnibus_version
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1462693 in cloud-init: "Need way to pin Chef version for omnibus install"
https://bugs.launchpad.net/
Diff comments:
> diff --git a/cloudinit/config/cc_runcmd.py b/cloudinit/config/cc_runcmd.py
> index 7c3ccd4..0899d15 100644
> --- a/cloudinit/config/cc_runcmd.py
> +++ b/cloudinit/config/cc_runcmd.py
> @@ -22,7 +23,7 @@ from textwrap import dedent
> # configuration options before actually attem
Diff comments:
> diff --git a/tests/unittests/test_runs/test_simple_run.py
> b/tests/unittests/test_runs/test_simple_run.py
> index 5cf666f..a8a2032 100644
> --- a/tests/unittests/test_runs/test_simple_run.py
> +++ b/tests/unittests/test_runs/test_simple_run.py
> @@ -63,5 +75,86 @@ class TestSi
The proposal to merge ~chad.smith/cloud-init:collect-logs into
cloud-init:master has been updated.
Description changed to:
cmdline: cloud-init collect-logs
Add a new collect-logs parameter to the cloud-init CLI. This script will
collect all logs pertinent to a cloud-init run and store them in a
The proposal to merge ~chad.smith/cloud-init:collect-logs into
cloud-init:master has been updated.
Description changed to:
cmdline: cloud-init collect-logs
Add a new collect-logs parameter to the cloud-init CLI. This script will
collect all logs pertinent to a cloud-init run and store them in a
Diff comments:
> diff --git a/cloudinit/stages.py b/cloudinit/stages.py
> index a1c4a51..1eb92cd 100644
> --- a/cloudinit/stages.py
> +++ b/cloudinit/stages.py
> @@ -821,28 +821,34 @@ class Modules(object):
> skipped = []
> forced = []
> overridden = self.cfg.get('unve
Diff comments:
> diff --git a/tools/xkvm b/tools/xkvm
> new file mode 100755
> index 000..a30ba91
> --- /dev/null
> +++ b/tools/xkvm
> @@ -0,0 +1,664 @@
> +#!/bin/bash
> +
Can you add a header comment here explaning what this is and how it's intended
for use?
> +set -f
> +
> +VERBOSITY=0
The proposal to merge ~chad.smith/cloud-init:collect-logs into
cloud-init:master has been updated.
Description changed to:
cmdline: cloud-init collect-logs
Add a new collect-logs parameter to the cloud-init CLI. This script will
collect all logs pertinent to a cloud-init run and store them in a
The proposal to merge ~chad.smith/cloud-init:config-modules-allow-distros-all
into cloud-init:master has been updated.
Commit Message changed to:
cloud-config modules: honor distros definitions in each module
Modules can optionally define a list of supported distros on which they can run
by de
Chad Smith has proposed merging
~chad.smith/cloud-init:tests-fix-root-os-access-leak into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330774
tests: mock calls to
I'm not quite sure what we should do here. You are right that root user will
likely never see os.access(W_OK) as False because root's a privileged user so
the perms don't matter.
Also, it seems that in containers we fail to resize up at cc_resizefs line 197
on ENOENT so generally trying to acco
The proposal to merge ~chad.smith/cloud-init:tests-fix-root-os-access-leak into
cloud-init:master has been updated.
Description changed to:
resizefs: Drop check and tests for read-only device file
As root user, os.access(, os.W_OK) will always return True so that path
will never get executed a
The proposal to merge ~chad.smith/cloud-init:tests-fix-root-os-access-leak into
cloud-init:master has been updated.
Commit Message changed to:
resizefs: Drop check and tests for read-only device file
As root user, os.access(, os.W_OK) will always return True so that path
will never get execute
Chad Smith has proposed merging ~chad.smith/cloud-init:dhclient-from-var-tmp
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330875
ec2: Fix
Diff comments:
> diff --git a/cloudinit/sources/DataSourceGCE.py
> b/cloudinit/sources/DataSourceGCE.py
> index 94484d6..5438842 100644
> --- a/cloudinit/sources/DataSourceGCE.py
> +++ b/cloudinit/sources/DataSourceGCE.py
> @@ -211,8 +209,17 @@ if __name__ == "__main__":
>
Test ran this on ass instances and cloud-init properly found Ec2Local
datasource with no traceback.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330875
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:dhclient-from-
Tested on AWS with success using needs_exe param:
2017-09-18 21:45:19,929 - util.py[DEBUG]: Copying /sbin/dhclient to
/var/tmp/cloud-init/cloud-init-dhcp-plxz9ijh/dhclient
2017-09-18 21:45:20,240 - handlers.py[DEBUG]: finish:
init-local/search-Ec2Local: SUCCESS: found local data from DataSourceEc
Chad Smith has proposed merging
~chad.smith/cloud-init:add-cloudinit-pkg-to-all-targets into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith
101 - 200 of 763 matches
Mail list logo
