Chad Smith has proposed merging
~chad.smith/cloud-init:bug/status-fix-done-status into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/337306
cli: fix cloud-init status
The proposal to merge ~chad.smith/cloud-init:bug/status-fix-done-status into
cloud-init:master has been updated.
Commit Message changed to:
cli: fix cloud-init status to report running when before result.json
Fix various corner cases for cloud-init status subcommand. Report
'runnning' under the
The proposal to merge ~chad.smith/cloud-init:bug/status-fix-done-status into
cloud-init:master has been updated.
Description changed to:
see commit message
to test:
# provide slow running cloud-config
cat >slow.yaml https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/33730
The proposal to merge ~chad.smith/cloud-init:bug/status-fix-done-status into
cloud-init:master has been updated.
Description changed to:
see commit message
to test:
# provide slow running cloud-config
cat >slow.yaml https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/33730
Chad Smith has proposed merging
~chad.smith/cloud-init:fix-instance-identity-upgrade-path into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/337475
ec2: fix upgrade
Chad Smith has proposed merging ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init
The proposal to merge ~chad.smith/cloud-init:doc-fix-chef-example into
cloud-init:master has been updated.
Commit Message changed to:
doc: trivial fix to chef install example for readthedocs content
Apt key was mistyped in the example.
Should be
apt:
sources:
source1:
instead of
apt:
Chad Smith has proposed merging ~chad.smith/cloud-init:doc-fix-chef-example
into cloud-init:master.
Commit message:
doc: trivial fix to chef install example for readthedocs content
Apt key was mistyped in the example.
Should be
apt:
sources:
source1:
instead of
apt:
source1
The proposal to merge ~chad.smith/cloud-init:doc-fix-chef-example into
cloud-init:master has been updated.
Description changed to:
To test:
tox -e doc # then point your browser to
file:doc/rtd_html/examples.html#install-and-run-chef-recipes
For more details, see:
https://code.launchpad
Chad Smith has proposed merging
~chad.smith/cloud-init:set-hostname-before-network into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/339720
set_hostname: When
The proposal to merge ~chad.smith/cloud-init:set-hostname-before-network into
cloud-init:master has been updated.
Description changed to:
set_hostname: When present in metadata, set it before network bringup.
When instance metadata/user-data provides hostname information, run
cc_set_hostname in
The proposal to merge ~chad.smith/cloud-init:set-hostname-before-network into
cloud-init:master has been updated.
Commit Message changed to:
set_hostname: When present in metadata, set it before network bringup.
When instance metadata/user-data provides hostname information, run
cc_set_hostname
The proposal to merge ~chad.smith/cloud-init:set-hostname-before-network into
cloud-init:master has been updated.
Description changed to:
See commit message
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/339720
--
Your team cloud-init commiters
Diff comments:
> diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py
> index a05ca2f..d1a213f 100644
> --- a/cloudinit/sources/__init__.py
> +++ b/cloudinit/sources/__init__.py
> @@ -276,21 +276,34 @@ class DataSource(object):
> return "iid-datasource"
>
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index d2f1b77..120c3cc 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -354,7 +355,17 @@ def main_init(name, args):
> LOG.debug("[%s] %s will now be targeting instance id: %s. new=%s",
>
You have been requested to review the proposed merge of
~d-info-e/cloud-init:salt-freebsd-patch into cloud-init:master.
For more details, see:
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/340112
the salt minion module was not really usable on FreeBSD so far. I have
adj
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Description changed to:
cc_snap: Add new module to install and configure snapd and snap packages.
Support installing and configuring snaps on ubuntu systems. Now,
cloud-config files can pro
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Description changed to:
see commit message.
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366
--
Your team cloud-init commiters is requ
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Commit Message changed to:
cc_snap: Add new module to install and configure snapd and snap packages.
Support installing and configuring snaps on ubuntu systems. Now,
cloud-config files can
Diff comments:
> diff --git a/tests/cloud_tests/testcases/modules/snap.py
> b/tests/cloud_tests/testcases/modules/snap.py
> new file mode 100644
> index 000..7120e3f
> --- /dev/null
> +++ b/tests/cloud_tests/testcases/modules/snap.py
> @@ -0,0 +1,132 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py
> new file mode 100644
> index 000..edb21bb
> --- /dev/null
> +++ b/cloudinit/config/cc_snap.py
> @@ -0,0 +1,272 @@
> +# Copyright (C) 2018 Canonical Ltd.
> +#
> +# This file is part of cloud-init. See LI
Chad Smith has proposed merging
~chad.smith/cloud-init:bug/util-subp-accepts-string-cmd into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341437
util: Fix subp
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Description changed to:
see commit message.
to test:
1. make a deb of this branch
make deb;
2. create a container and install the deb
lxc launch ubuntu-daily/bionic myb1;
lxc file push clou
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Description changed to:
see commit message.
to test:
1. make a deb of this branch
make deb;
2. create a container and install the deb
lxc launch ubuntu-daily/bionic myb1;
lxc file push clou
Diff comments:
> diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py
> new file mode 100644
> index 000..3210d6d
> --- /dev/null
> +++ b/cloudinit/config/cc_snap.py
> @@ -0,0 +1,272 @@
> +# Copyright (C) 2018 Canonical Ltd.
> +#
> +# This file is part of cloud-init. See LI
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/ubuntu-advantage-module into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith
The proposal to merge ~chad.smith/cloud-init:feature/ubuntu-advantage-module
into cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341542
--
Your team cloud-init commiters i
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/ubuntu-advantage-module into cloud-init:master
with ~chad.smith/cloud-init:feature/snap-module as a prerequisite.
Commit message:
ubuntu-advantage: Add new config module to support ubuntu-advantage-tools
ubuntu-advantage-tools is a
The proposal to merge
~smoser/cloud-init:fix/2.6-pylint-happy-with-assert-raises-regex into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341530
--
Your team cloud-init commit
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366
--
Your team cloud-init commiters is requested to
An upstream commit landed for this bug.
To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=a1f678f8
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366
Your team cloud-init commiters is requested to review the proposed merge
The proposal to merge ~chad.smith/cloud-init:feature/snap-module into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366
--
Your team cloud-init commiters is requested to revie
Diff comments:
> diff --git a/cloudinit/config/cc_ubuntu_advantage.py
> b/cloudinit/config/cc_ubuntu_advantage.py
> new file mode 100644
> index 000..e941cc0
> --- /dev/null
> +++ b/cloudinit/config/cc_ubuntu_advantage.py
> @@ -0,0 +1,217 @@
> +# Copyright (C) 2018 Canonical Ltd.
> +#
> +#
The proposal to merge
~chad.smith/cloud-init:fix/bug-1757176-get-host-name-metadata-only into
cloud-init:master has been updated.
Commit Message changed to:
datasources: fix DataSource subclass get_hostname method signature
DataSource.get_hostname call signature changed to allow for metadata_o
The proposal to merge
~chad.smith/cloud-init:fix/bug-1757176-get-host-name-metadata-only into
cloud-init:master has been updated.
Description changed to:
see commit message.
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341757
--
Your team clo
Chad Smith has proposed merging
~chad.smith/cloud-init:fix/bug-1757176-get-host-name-metadata-only into
cloud-init:master.
Commit message:
datasources: fix DataSource subclass get_hostname method signature
DataSource.get_hostname call signature changed to allow for metadata_only
parameter
Validated with and without this patch on Xenial (upgraded to this version of
cloud-init)
Failure mode: https://pastebin.ubuntu.com/p/NpMNDVMhz6/ reproduces traceback
success with this patchset.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341757
Your team cloud-init
Diff comments:
> diff --git a/cloudinit/config/tests/test_ubuntu_advantage.py
> b/cloudinit/config/tests/test_ubuntu_advantage.py
> new file mode 100644
> index 000..476ff1d
> --- /dev/null
> +++ b/cloudinit/config/tests/test_ubuntu_advantage.py
> @@ -0,0 +1,318 @@
> +# This file is part of
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> index 9c5628e..ed654c4 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -502,6 +507,12 @@ VALID_CFG = {
> 'policy_dmi': POLICY_
Diff comments:
> diff --git a/cloudinit/sources/DataSourceIBMCloud.py
> b/cloudinit/sources/DataSourceIBMCloud.py
> new file mode 100644
> index 000..fa6cef0
> --- /dev/null
> +++ b/cloudinit/sources/DataSourceIBMCloud.py
> @@ -0,0 +1,311 @@
> +# This file is part of cloud-init. See LICENSE
> Aren't you missing an entry in config/cloud.cfg.tmpl for this to run?
Absolutely. you got me, and I just tried running minimal ua commands on an lxc
with cloud.cfg.tmpl enabled in my latest branch and it works.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341543
Y
The proposal to merge
~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341995
--
Your team cloud-init commiters
Chad Smith has proposed merging
~chad.smith/cloud-init:fix/add-ibmcloud-to-settings into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342019
Add unit tests for
The proposal to merge ~chad.smith/cloud-init:fix/add-ibmcloud-to-settings into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342019
--
Your team cloud-init commiters is req
The proposal to merge ~chad.smith/cloud-init:fix/add-ibmcloud-to-settings into
cloud-init:master has been updated.
Description changed to:
See commit message:
Added unit test fix for Scott's branch updating settings.
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/
The proposal to merge ~chad.smith/cloud-init:fix/add-ibmcloud-to-settings into
cloud-init:master has been updated.
Commit Message changed to:
Enable IBMCloud datasource in settings.py.
This just got missed in the IBMCloud datasource addition.
Add it to the builtin list of datasources.
For more
minor inline comments, I'll have a pastebin of the updated schema dictionary as
I see it shaping up.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..099b8d8 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -8
More minor inline comments and updated schema @
http://paste.ubuntu.com/p/2by6yyn8dT/
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..099b8d8 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -83,7 +102,56 @
Chad Smith has proposed merging ~chad.smith/cloud-init:puppet-flakes into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342154
cc_puppet: Revert regression of puppet
Chad Smith has proposed merging ~chad.smith/cloud-init:release-18.2 into
cloud-init:master.
Commit message:
release 18.2
Bump the version in cloudinit/version.py to be 18.2 and update ChangeLog.
LP: #1759318
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug
+1 on the content of the changeset. tested on a container without Nocloud seed
to see Hetzner rejected quickly.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342226
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/hetzne
The proposal to merge ~smoser/cloud-init:fix/hetzner-ds-check-vendor into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342226
--
Your team cloud-init commiters is requested to
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/artful into
cloud-init:ubuntu/artful.
Commit message:
Proposing a sync of tip for release into Artful using fixes to
new-upstream-release.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https
The proposal to merge
~smoser/cloud-init:ubuntu/devel-drop-new-upstream-snapshot into
cloud-init:ubuntu/devel has been updated.
Commit message changed to:
debian/new-upstream-snapshot: remove from package.
This is no longer managed in the packaging branches.
For more details, see:
https://cod
The proposal to merge
~smoser/cloud-init:ubuntu/xenial-drop-new-upstream-snapshot into
cloud-init:ubuntu/xenial has been updated.
Commit message changed to:
debian/new-upstream-snapshot: remove from package.
This is no longer managed in the packaging branches.
For more details, see:
https://c
The proposal to merge
~smoser/cloud-init:ubuntu/artful-drop-new-upstream-snapshot into
cloud-init:ubuntu/artful has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342336
--
Your team cloud-init comm
LGTM!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342334
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:ubuntu/devel-drop-new-upstream-snapshot into
cloud-init:ubuntu/devel.
_
The proposal to merge
~smoser/cloud-init:ubuntu/devel-drop-new-upstream-snapshot into
cloud-init:ubuntu/devel has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342334
--
Your team cloud-init commit
+1 on changing any hyphenat-delimited keys to underscore-delimited "_". If
there are any inconsistencies there in the code honoring underscore-delmited
keys we will fix the code. Consistency across all applicable user-provided
fields pays dividends.
Dominic, I'll await your final pass on this a
Chad Smith has proposed merging
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master.
Commit message:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped.
Where possible
The proposal to merge ~raharper/cloud-init:fix/cc_resizefs_on_zfs_root into
cloud-init:master has been updated.
Commit message changed to:
cc_resizefs, util: handle no /dev/zfs
The zfs/zpool commands will hang for 10 seconds if /dev/zfs is not
present (bug 1760173). This is a common occurence
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..a6f8a1d 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -83,7 +183,75 @@ schema = {
> List of ntp servers. If both pools and servers a
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..a6f8a1d 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -21,9 +23,80 @@ LOG = logging.getLogger(__name__)
>
> frequency = PER_INSTANCE
> NTP_CONF = '/etc/n
round 2 inline comments. please rebase too to reduce the diff delta with zfs
changes which have landed.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..a6f8a1d 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..57a732f 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -94,68 +264,84 @@ schema = {
> __doc__ = get_schema_doc(schema) # Supplement python help()
>
>
>
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial.
Commit message:
Sync tip of cloud-init master to get SRU-related zfs fixes from tip into
Xenial-proposed.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1420018
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/artful into
cloud-init:ubuntu/artful.
Commit message:
Sync tip of cloud-init master containing zfs fixes for release into Artful.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1420018 in cloud-init
Diff comments:
> diff --git a/cloudinit/ec2_utils.py b/cloudinit/ec2_utils.py
> index dc3f0fc..18553f0 100644
> --- a/cloudinit/ec2_utils.py
> +++ b/cloudinit/ec2_utils.py
> @@ -134,9 +134,9 @@ class MetadataMaterializer(object):
> return joined
>
>
> -def _skip_retry_on_codes(statu
The proposal to merge ~chad.smith/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342606
--
Your team cloud-init commiters is requested t
Chad Smith has proposed merging ~chad.smith/cloud-init:fix/pylxd-3.0 into
cloud-init:master.
Commit message:
tests: fix integration tests to support lxd 3.0 release
Integration tests previously had a logic path that was unexercised on
jenkins because we were on an older version of lxc. With
Chad Smith has proposed merging ~chad.smith/cloud-init:fix-make-tarball into
cloud-init:master.
Commit message:
tools: Fix make-tarball cli tool usage and default tar.gz outfile
This tool is used to assist during the creation of ubuntu packages for
release testing. make-tarball default outfile
The proposal to merge ~kgarloff/cloud-init:detect_otc_as_openstack_ds into
cloud-init:master has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845
--
Your team cloud-init commiters is requested
Kurt, thanks for the work on this, your work has landed in 18.2 cloud-init
version 18.2 and is currently present in bionic (and xenial-proposed pocket).
If you wish to test it out cloud-init 18.2 or greater will have the
functionality you need as the branch which landed your functionality is her
Chad Smith has proposed merging ~chad.smith/cloud-init:fix/cloud-tests-ec2 into
cloud-init:master.
Commit message:
tests: fix ec2 integration network metadata validation
Fix integraiton test logic for ec2 to look for network and
availability-zone data under the key path
'ds'=&
The proposal to merge ~chad.smith/cloud-init:fix/cloud-tests-ec2 into
cloud-init:master has been updated.
Description changed to:
Tested this on torkoal via running the newly fixed jenkins job
https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-integration-proposed-a/
For more det
The proposal to merge ~chad.smith/cloud-init:fix/cloud-tests-ec2 into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342830
--
Your team cloud-init commiters is requested to
Validated ipv6 route information shown using this branch
https://pastebin.ubuntu.com/p/PNFXM8SCCY/
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342428
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:net-tools-depre
The proposal to merge
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master has been updated.
Commit message changed to:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped.
Us
The proposal to merge
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master has been updated.
Commit message changed to:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped.
Us
I feel like we could do a bit better validation on the user-provided config
keys with a simple validate_config function that'd raise understandable errors
on misconfig for certain keys:
Here are some examples of easy and hard tracebacks to understand, as the person
can't just run cloud-init sta
> If you've got some changes to make the validation check tighter, I'm happy to
> have those; and I agree that if status --long can emit exactly the error
> that's really nice.
Here's some tested code I ran on lxc's with sparse/incorrect user-data. it
tightens up the error reporting so cloud-ini
oops lints/flakes fixed http://paste.ubuntu.com/p/5Zv2WTX9Rf/
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:feature/update-ntp-spec into cloud-init:master.
___
> The commit is missing cc_disable_ec2_metadata.py which uses the "route"
> command from net-tools command
>
> Too bad this had to be started over rather than beating the since last year
> pending request into shape.
Sorry Robert, shameful review queue mismanagement on my part. I was fixated on
The proposal to merge
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master has been updated.
Commit message changed to:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped.
Us
All comments addressed. Please glance over the changes if you get a chance.
Diff comments:
> diff --git a/cloudinit/netinfo.py b/cloudinit/netinfo.py
> index 993b26c..081f7b4 100644
> --- a/cloudinit/netinfo.py
> +++ b/cloudinit/netinfo.py
> @@ -18,18 +21,81 @@ from cloudinit.simpletable import S
The proposal to merge
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master has been updated.
Commit message changed to:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped.
Us
The proposal to merge
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master has been updated.
Commit message changed to:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped. U
Diff comments:
> diff --git a/cloudinit/netinfo.py b/cloudinit/netinfo.py
> index 993b26c..a8c7f7a 100644
> --- a/cloudinit/netinfo.py
> +++ b/cloudinit/netinfo.py
> @@ -18,18 +20,89 @@ from cloudinit.simpletable import SimpleTable
> LOG = logging.getLogger()
>
>
> -def netdev_info(empty=""
The proposal to merge
~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into
cloud-init:master has been updated.
Commit message changed to:
net: Depend on iproute2's ip instead of net-tools ifconfig or route
The net-tools package is deprecated and will eventually be dropped. U
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/devel into
cloud-init:ubuntu/devel.
Commit message:
Sync bugfixes from master into Bionic for release
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1667735 in cloud-init: "cloud-init doesn&#x
This is good, better to be flexible in the event users need to run the same
command multiple times. As you mentioned in irc apt-get update may frequently
show up multiple times.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343575
Your team cloud-init commiters is reque
I like the idea; and the fix is needed. I just have a question about whether we
can find a way to generalize that validate_or_fail method and avoid duplication.
Diff comments:
> diff --git a/cloudinit/config/tests/test_snap.py
> b/cloudinit/config/tests/test_snap.py
> index 492d2d4..cb0e5bb 100
Good changeset and simplification magic based on top-level key.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343609
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/jsonschema-follow-on into cloud-init:master.
_
The proposal to merge ~smoser/cloud-init:ubuntu/devel-isc-dhcp-client-fix into
cloud-init:ubuntu/devel has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/344186
--
Your team cloud-init commiters is r
The proposal to merge
~smoser/cloud-init:ubuntu/devel-17661711-add-iproute2-depends into
cloud-init:ubuntu/devel has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/344189
--
Your team cloud-init com
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/artful into
cloud-init:ubuntu/artful.
Commit message:
Cherry pick fixes for IBMCloud upgrades from 17.1 -> 18.2 (artful-proposed)
Addresses the following bugs:
LP: #1766401
LP: #1767166
Requested reviews:
cloud-init commit
The proposal to merge ~smoser/cloud-init:cleanup/collect-logs-stderr into
cloud-init:master has been updated.
Commit message changed to:
collect-logs: add -v flag, write to stderr, limit journal to single boot.
With no output at all from collect-logs, users have been confused
on where the outpu
Diff comments:
> diff --git a/cloudinit/cmd/devel/logs.py b/cloudinit/cmd/devel/logs.py
> index 35ca478..9f8f540 100644
> --- a/cloudinit/cmd/devel/logs.py
> +++ b/cloudinit/cmd/devel/logs.py
> @@ -64,28 +83,48 @@ def collect_logs(tarfile, include_userdata):
> log_dir = 'cloud-init-logs-{0}
The proposal to merge ~smoser/cloud-init:cleanup/collect-logs-stderr into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/344894
--
Your team cloud-init commiters is requested to
The proposal to merge ~smoser/cloud-init:tools/bddeb-reuse-tarball into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/344545
--
Your team cloud-init commiters is requested to r
301 - 400 of 763 matches
Mail list logo
