The proposal to merge ~legovini/cloud-init:copr-fix into cloud-init:master has
been updated.
Commit message changed to:
When using a proxy it is often useful to know in advance which mirrors are to
be contacted, so a whitelist can be set up. This is not easy when using the
yum.conf(5)
Paride Legovini has proposed merging ~legovini/cloud-init:copr-fix into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~legovini/cloud-init/+git/cloud-init/+merge/362123
--
Your team cloud-init commiters
When using a proxy it is often useful to know in advance which mirrors are to
be contacted, so a whitelist can be set up. This is not easy when using the
yum.conf(5) mirrorlist option, as the retrieved list of mirrors may change. The
repository definition may also specify a canonical mirror
Paride Legovini has proposed merging ~legovini/cloud-init:fix/tox-flake8 into
cloud-init:master.
Commit message:
flake8: use ==/!= to compare str, bytes, and int literals
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~legovini
Paride Legovini has proposed merging ~legovini/cloud-init:fix/tox-flake8 into
cloud-init:master.
Commit message:
flake8: use ==/!= to compare str, bytes, and int literals
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~legovini
Paride Legovini has proposed merging
~legovini/cloud-init:copr-disable-mirrorlist into cloud-init:master.
Commit message:
run-container: centos: comment out the repo mirrorlist
In this way only the 'baseurl' mirror is used, which is easier
to allow through firewalls and proxies.
Requested
Paride Legovini has proposed merging ~legovini/cloud-init:eoan-tests into
cloud-init:master.
Commit message:
tests: add Eoan release
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~legovini/cloud-init/+git/cloud-init/+merge/367210
tox -e citest -- run --os-name=eoan --preserve-data --data-dir=results
--deb=cloud-init_18.5-75-g2d6c564e-1~bddeb_all.deb
reported:
citest: commands succeeded
congratulations :)
--
https://code.launchpad.net/~legovini/cloud-init/+git/cloud-init/+merge/367210
Your team cloud-init commiters
In general LVGTM; I left a couple of nitpick comments inline.
Diff comments:
> diff --git a/README.md b/README.md
> new file mode 100644
> index 000..04045e8
> --- /dev/null
> +++ b/README.md
> @@ -0,0 +1,76 @@
> +# Cloud-init official mirror synced from https://launchpad.net/cloud-init
> +
Paride Legovini has proposed merging ~legovini/cloud-init:migrate-lp-to-github
into cloud-init:master.
Commit message:
lp-to-git-users: adding paride
Mapped from legovini
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~legovini
Review: Approve
LGTM
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043
Your team cloud-init Commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master.
Review: Approve
Right. In the usual failure mode retrying should work even without sleeping,
but it's way better to add a sleep(1) there.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043
Your team cloud-init Commiters is requested to review the proposed merge of
12 matches
Mail list logo
