The proposal to merge ~jcastets/cloud-init:fix-net-cfg into cloud-init:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
--
Your team cloud init development team is requested to revi
The proposal to merge ~jcastets/cloud-init:fix-net-cfg into cloud-init:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
--
Your team cloud init development team is requested to review the
The proposal to merge ~smoser/cloud-init:bug/1689944-improve-system-is-snappy
into cloud-init:master has been updated.
Commit Message changed to:
Improve detection of snappy to include os-release and kernel cmdline.
Recent core snap images (edge channel revision 1886) do not contain the
previou
Scott Moser has proposed merging
~smoser/cloud-init:bug/1689944-improve-system-is-snappy into cloud-init:master.
Commit message:
Improve detection of snappy to include os-release and kernel cmdline.
Recent core snap images (edge channel revision 1886) do not contain the
previously known files
The proposal to merge ~raharper/cloud-init:fix-net-convert into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/323083
--
Your team cloud-init commiters is requested to review
The proposal to merge ~raharper/cloud-init:fix-net-convert into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/323083
--
Your team cloud-init commiters is requested to review the pr
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323076
--
Your team cloud-init commiters is requested to revi
Scott Moser has proposed merging ~smoser/cloud-init:bug/before-fsck into
cloud-init:master.
Commit message:
systemd: make systemd-fsck run after cloud-init.service
cloud-init.service may write filesystems (fs_setup) or re-partition
(disk_setup) disks.
If systemd-fsck is running on a device
The proposal to merge ~smoser/cloud-init:bug/before-fsck into cloud-init:master
has been updated.
Commit Message changed to:
systemd: make systemd-fsck run after cloud-init.service
cloud-init.service may write filesystems (fs_setup) or re-partition
(disk_setup) disks.
If systemd-fsck is runnin
This *seems* to work for me, but I'd like to have some review by someone else
who is knowledgeable in systemd.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/before-
Can we instead mock the which ?
As the test is now, this will fail if there is no mkfs.ext4.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324201
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:fix-test-mkfs into cloud-in
The proposal to merge ~chris-brinker/cloud-init:actually-skip-warnings into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chris-brinker/cloud-init/+git/cloud-init/+merge/323406
--
Your team cloud-init commiters is req
Scott Moser has proposed merging
~smoser/cloud-init:bug/1683038-ec2-no-warn-on-explicit into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1683038 in cloud-init: "Need to convince cloud-init we really want Ec2
datasource&quo
The proposal to merge ~smoser/cloud-init:bug/1683038-ec2-no-warn-on-explicit
into cloud-init:master has been updated.
Commit Message changed to:
Ec2: do not warn user of strict if Ec2 is explicitly set.
If the system is configured with datasource_list of either just
'Ec2' or 'Ec2' and 'None', t
Vladimir,
This looks really good, thank you.
I'd like to update doc/rtd/topics/datasources/nocloud.rst with an example on
how to use this directly with a qemu cmdline.
Also I think the kernel cmdline should override the smbios information.
--
https://code.launchpad.net/~farcaller/cloud-init/+
The proposal to merge ~farcaller/cloud-init:nocloud-dmi into cloud-init:master
has been updated.
Commit Message changed to:
NoCloud: support seed of nocloud from smbios information
This allows the user to seed NoCloud in a trivial way from qemu/libvirt, by
using a stock image and passing a sing
The commit message needs updating for sure.
You mention tox 'citest', but do not make any changes to it.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:integration-te
The proposal to merge ~smoser/cloud-init:bug/1692028-empty-macs-for-bymac into
cloud-init:master has been updated.
Commit Message changed to:
Fix get_interfaces_by_mac for empty macs
Some interfaces (greptap0 in the bug) have a mac address of
'00:00:00:00:00:00'. That was causing a duplicate m
Scott Moser has proposed merging
~smoser/cloud-init:bug/1692028-empty-macs-for-bymac into cloud-init:master.
Commit message:
Fix get_interfaces_by_mac for empty macs
Some interfaces (greptap0 in the bug) have a mac address of
'00:00:00:00:00:00'. That was causing a duplicate mac de
I'm not sure where this 'gretap0' device comes from or if it would ever appear
in the network data. I'd suggest that it would be bad for it to...
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324332
Your team cloud-init commiters is requested to review the proposed merg
The proposal to merge
~smoser/cloud-init:bug/1692087-disk_setup-gpt-improvements into
cloud-init:master has been updated.
Commit Message changed to:
disk_setup: fix several issues with gpt disk partitions.
This fixes several shortcomings of disk_setup with gpt disks.
* 'sgdisk -p' was being u
Scott Moser has proposed merging
~smoser/cloud-init:bug/1692087-disk_setup-gpt-improvements into
cloud-init:master.
Commit message:
disk_setup: fix several issues with gpt disk partitions.
This fixes several shortcomings of disk_setup with gpt disks.
* 'sgdisk -p' was being used to
I generally agree with your comments.
The code needs overhaul and better tests.
I'm trying to avoid doing too much to it now.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index 29eb5dd..e1505b3 100644
> --- a/cloudinit/config/cc_disk_se
The proposal to merge
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master has been updated.
Commit Message changed to:
pylint: make tox -e pylint-tip pass by ignoring a misreported error.
This just silences a warning in pylint. The issue is reported u
Scott Moser has proposed merging
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master.
Commit message:
pylint: make tox -e pylint-tip pass by ignoring a misreported error.
This just silences a warning in pylint. The issue is reported upstream
at https
The proposal to merge
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master has been updated.
Commit Message changed to:
pylint: make tox -e pylint-tip pass by ignoring a misreported error.
This just silences a warning that is generated in pylint 1.7.1,
The systemd changes are not actually present.
They were a result of me being on a branch
(https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191)
when i created *this* branch.
They're not present any more, launchpad just isn't updating the diff that you
see.
If you look at
The proposal to merge
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master has been updated.
Commit Message changed to:
tox: move pylint target to 1.7.1
The motivation for this is to make tip-pylint target green.
It does 2 things:
a.) silence a warning
On Mon, 22 May 2017, Ryan Harper wrote:
> Generally looks fine, one question w.r.t confirming explict_dslist check
>
> Diff comments:
>
> > diff --git a/cloudinit/sources/DataSourceEc2.py
> > b/cloudinit/sources/DataSourceEc2.py
> > index 2f9c7ed..818a639 100644
> > --- a/cloudinit/sources/DataSo
Scott Moser has proposed merging ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
--
Your team cloud-init commiters is
The proposal to merge ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master has been updated.
Commit Message changed to:
flake8: move the pinned version of flake8 up to 3.3.0
This just moves flake8 and related tools up to newer versions and fixes the
complaints associated with that.
The proposal to merge ~smoser/cloud-init:feature/flake8-upgrade into
cloud-init:master has been updated.
Commit Message changed to:
flake8: move the pinned version of flake8 up to 3.3.0
This just moves flake8 and related tools up to newer versions and fixes the
complaints associated with that.
I expect :vi info in files (H102)
for H304, I dont have strong feelings. we could fix these.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/flake8-upgrade into c
for quick reference, H304 shows:
http://paste.ubuntu.com/24635484/
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/flake8-upgrade into cloud-init:master.
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can now
some comments in line.
I'm generally in agreement here.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -53,14 +53,12 @@ distros = ['centos', 'debian'
some responses in line. i'll fix some things too. thanks for review.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@
I've pushed some new commits, please see and review.
thanks.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
probably.
I
Hm..
So after doing this I noticed that pep8 is still in my tox flake8 env and
wondered why.
$ pip check
hacking 0.13.0 has requirement flake8<2.6.0,>=2.5.4, but you have flake8 3.3.0.
hacking 0.13.0 has requirement mccabe==0.2.1, but you have mccabe 0.6.1.
hacking 0.13.0 has requirement pyflakes
https://bugs.launchpad.net/hacking/+bug/1607942
is a 'hacking' upstream bug on versions.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/flake8-upgrade into clou
Given that these are all generally acceptable changes I'm going to pull this.
Even if its possible we'd find fallout of the hacking issue.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed merge of
~
Scott Moser has proposed merging
~smoser/cloud-init:bug/package-build-no-stylechecks into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324541
--
Your team cloud-init
The proposal to merge ~smoser/cloud-init:bug/package-build-no-stylechecks into
cloud-init:master has been updated.
Commit Message changed to:
tox/build: do not package depend on style requirements.
When the style/checking dependencies were updated in
test-requirements.txt, the debian package bu
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Description changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can now ma
I'm going to mark this 'work in progress'. Josh has integrated this branch and
others into his merge proposal at
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136 .
We do plan to pull that all soon.
Thanks for your work, Wesley!
--
https://code.launchpad.net/~wesle
The proposal to merge
~wesley-wiedenmeier/cloud-init:integration-testing-invocation-cleanup into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/314496
--
Yo
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218
--
Your team cloud-init c
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing-tmpdir
into cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/320401
--
Your team cloud
I'm going to mark this 'work in progress'. Josh has integrated this branch and
others into his merge proposal at
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136 .
We do plan to pull that all soon.
Thanks for your work, Wesley!
--
https://code.launchpad.net/~wesle
I'm going to mark this 'work in progress'. Josh has integrated this branch and
others into his merge proposal at
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136 .
We do plan to pull that all soon.
Thanks for your work, Wesley!
--
https://code.launchpad.net/~wesle
The proposal to merge
~wesley-wiedenmeier/cloud-init:integration-testing-distro-features into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/321029
--
Your
I'm going to mark this 'work in progress'. Josh has integrated this branch and
others into his merge proposal at
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136 .
We do plan to pull that all soon.
Thanks for your work, Wesley!
--
https://code.launchpad.net/~wesle
Marc,
This looks good. Some comments... they're all minor, and should be explained
more in HACKING.rst
http://cloudinit.readthedocs.io/en/latest/topics/hacking.html
a.) change description to be
Summary
Description
b.) lets go ahead and just keep the function in a net/__init__.py
Scott Moser has proposed merging
~smoser/cloud-init:bug/ds-identify-list-none-twice into cloud-init:master.
Commit message:
fix tools/ds-identify to not write None twice.
If the user configured:
datasource_list: ["Ec2", "None"]
then ds-identify would write
datasource
The proposal to merge ~smoser/cloud-init:bug/ds-identify-list-none-twice into
cloud-init:master has been updated.
Commit Message changed to:
fix tools/ds-identify to not write None twice.
If the user configured:
datasource_list: ["Ec2", "None"]
then ds-identify would write
datasource_list:
I split the ds-identify portion out into
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324557
that way i can get it in now, and fix the ec2 warn portion itself with a nice
test.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324274
Your team clou
The proposal to merge ~smoser/cloud-init:bug/fix-py26-tests-assertNone into
cloud-init:master has been updated.
Commit Message changed to:
tests: fix unit tests usage of assertNone on centos 6.
python2.6 unittest.TestCase does not have the assertIsNone or
assertIsNotNone. We just have to expli
Scott Moser has proposed merging
~smoser/cloud-init:bug/fix-py26-tests-assertNone into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324585
--
Your team cloud-init
The proposal to merge ~smoser/cloud-init:bug/fix-py26-tests-assertNone into
cloud-init:master has been updated.
Commit Message changed to:
tests: fix unit tests usage of assertNone on centos 6.
python2.6 unittest.TestCase does not have the assertIsNone or
assertIsNotNone. We just have to expli
Scott Moser has proposed merging ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master.
Commit message:
AliYun: Enable platform identification and enable by default.
AliYun cloud platform is now identifying themselves by setting the dmi
product id to the well known value "Al
This supersedes
https://code.launchpad.net/~jingni.wjj/cloud-init/+git/cloud-init/+merge/323306.
It has some re-wording of Junjie's commit, and then a commit to show my
additional changes.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
Your team cloud-init commite
The proposal to merge ~smoser/cloud-init:bug/1692093-sometimes-need-settle into
cloud-init:master has been updated.
Commit Message changed to:
disk_setup: udev settle before attempting partitioning or fs creation.
This attempts to use udevadm settle to wait until devices have been
fully "realiz
Scott Moser has proposed merging
~smoser/cloud-init:bug/1692093-sometimes-need-settle into cloud-init:master.
Commit message:
disk_setup: udev settle before attempting partitioning or fs creation.
This attempts to use udevadm settle to wait until devices have been
fully "realized". I
I like it very much.
Some comments inline. comments.
looking at diff i see that tools/cloudconfig-schema has some
whitespace-end-of-line issues.
tools/cloudconfig-schema needs chmod +x.
tools/cloudconfig-schema: def error() should got to sys.stderr.write(message +
"\n") ?
might as well write e
I think i'm going to drop the blockdev --rereadpt
It should not strictly be needed during boot.
a udevadm settle shoudl be sufficient.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324639
Your team cloud-init commiters is requested to review the proposed merge of
~smose
This has no merge proposal shown because of bug 1693543
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -737,6 +737,21 @@ def exec_mkpart(table_type, device, layout):
> re
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 5cc5453..f2eb5a6 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -52,21 +54,79 @@ NR_POOL_SERVERS = 4
> distros = ['centos', 'debian', 'fedora', 'opensuse', 'ubuntu']
dropping blkid:
https://git.launchpad.net/~smoser/cloud-init/commit/?id=6b0c90d33703ac075c42bb4a52d710f636d5a030
See that commit.
I *had* a blkid --rereadpt between the two udevadm calls in
assert_and_settle_device. I dropped that.
the 'blkid --rereadpt' that you see is in 'read_parttbl', whi
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/mask2cidr into
cloud-init:master.
Commit message:
place holder
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324677
--
Your team
The proposal to merge
~raharper/cloud-init:eni-drop-rendering-systemd-link-files into
cloud-init:master has been updated.
Description changed to:
cloudinit.net: remove systemd link file writing from eni renderer
During the network v2 merge, we re-enabled rendering systemd .link files.
This fil
The proposal to merge ~akaris/cloud-init:bug1684349 into cloud-init:master has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~akaris/cloud-init/+git/cloud-init/+merge/322992
--
Your team cloud-init commiters is requested to review the propose
I've marked this 'merged'
the change was present at
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324010
i have a lot of further improvements to that general area, fixing Andreas's
issues with the type safety of that function. Theres more to do, but you can
see at
https:/
> Thanks for this good work approved pending your decision on the following
> comments.
>
> My comments will be made per the consolidated visual diff @
> http://paste.ubuntu.com/24716726/
>
> line 49 in the above diff:
> Since order of datasources matters to determine which datasource is detectr
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
--
Your team cloud-init commiters is requested to rev
Scott Moser has proposed merging ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master.
Commit message:
AliYun: Enable platform identification and enable by default.
AliYun cloud platform is now identifying themselves by setting the dmi
product id to the well known value "Al
OK, So i thought some more, and with regard to the order of the two
'datasource_lists'.
Some points to think about
a.) If EC2's 'strict_id' is set to "warn" or "false", then the Ec2 datasource
will poll and time out very annoyingly. "true" is the default setting in
trunk, but not yet in xenial.
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
--
Your team cloud-init commiters is requested to revie
The proposal to merge ~smoser/cloud-init:bug/1683038-ec2-no-warn-on-explicit
into cloud-init:master has been updated.
Commit Message changed to:
Ec2: do not warn user of strict if Ec2 is explicitly set.
If the system is configured with datasource_list of either just
'Ec2' or 'Ec2' and 'None', t
I have to think some more on the 'FIXME' bits here.
But i'd like feedback on teh added unit tests.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324274
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/1683038-ec2-no-warn
I have only one comment, and i'm fine with it as it is.
Could we put the main into cloudinit/config/schema.py ?
Then it would be executable on any system with cloud-init as:
python3 -m cloudinit.config.schema
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324640
Yo
https://gist.github.com/smoser/a5435f49b61e2ae45c367bbb266bfac3
Add DI_DMI_CHASSIS_ASSET_TAG to _print_info in tools/ds-identify.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index b9458ff..9dc9157 100644
> --- a/cloudinit/sour
responded to rharper's comments. i think he reviewed an older version though.
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index db3c357..9def76d 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -289,19 +
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index db3c357..ef000ae 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,6 +670,125 @@ class NetworkStateInterpreter(object):
> return subnets
>
thanks for the reviews.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324677
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/mask2cidr into cloud-init:master.
___
Mailing
The proposal to merge ~smoser/cloud-init:feature/net-convert-work-with-old into
cloud-init:master has been updated.
Commit Message changed to:
tools/net-convert.py: support old cloudinit versions by using kwargs.
Older cloud-init versions have a bug in the signature of the
render_network_state
I found this when wanting to use the trunk's tools/net-convert.py against a
dpkg installed version of cloud-init on xenial.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324948
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-in
Scott Moser has proposed merging
~smoser/cloud-init:feature/net-convert-work-with-old into cloud-init:master.
Commit message:
tools/net-convert.py: support old cloudinit versions by using kwargs.
Older cloud-init versions have a bug in the signature of the
render_network_state method for
bunch of fixes in tree now. i thikn i addressed all feedback.
Diff comments:
> diff --git a/cloudinit/net/netplan.py b/cloudinit/net/netplan.py
> index d7ddf0c..6754330 100644
> --- a/cloudinit/net/netplan.py
> +++ b/cloudinit/net/netplan.py
> @@ -119,8 +119,8 @@ def _extract_addresses(config, e
i've just rebased on master.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324677
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/mask2cidr into cloud-init:master.
___
Mai
The proposal to merge ~smoser/cloud-init:cleanup/mask2cidr into
cloud-init:master has been updated.
Commit Message changed to:
net: normalize data in network_state object
the network_state object's network and route keys would have different
information depending upon how the network_state obje
fixed all that round of comments.
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 9e9c05a..1d92db0 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,53 +670,213 @@ class NetworkStateInterpreter(obje
i use 'newscript' to create scripts once they start needing options.
make sure you use it with '--spaces'
http://smoser.brickies.net/git/?p=tildabin.git;a=blob;f=newscript;h=494d31a8f8fa0c83d7c8b03d3d63deb641709b99;hb=HEAD
Diff comments:
> diff --git a/tools/test-centos-run.sh b/tools/test-cento
The proposal to merge
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
--
Your team cloud-init c
The proposal to merge
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
--
Your team cloud-init commite
Balint,
Could you please comment on this?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/before-fsck into cloud-init:master.
___
Hi,
I'm marking this as 'merged' based on the fact that the new merge proposal *is*
merged.
(https://code.launchpad.net/~akaris/cloud-init/+git/cloud-init/+merge/324196)
Please move back to 'Needs Review' (and explain) if you think otherwise.
Diff comments:
> diff --git a/cloudinit/net/sysconf
The proposal to merge ~tell1ng/cloud-init:fix-typos-and-whitespaces into
cloud-init:master has been updated.
Description changed to:
docs: fix typos and removes some whitespace.
For more details, see:
https://code.launchpad.net/~tell1ng/cloud-init/+git/cloud-init/+merge/324966
--
Your team clo
The proposal to merge lp:~harlowja/cloud-init/tox-venvs into
lp:~cloud-init-dev/cloud-init/trunk has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~harlowja/cloud-init/tox-venvs/+merge/203225
--
Your team cloud-init commiters is requested to
marking this merged.
we use tox in trunk now.
if you think there is something missing, please propose a merge to cloud-init
git.
thanks.
--
https://code.launchpad.net/~harlowja/cloud-init/tox-venvs/+merge/203225
Your team cloud-init commiters is requested to review the proposed merge of
lp:~har
501 - 600 of 1711 matches
Mail list logo
